Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#17760 closed defect (fixed)

IndirectSelection plugin for EnhancedGrid does not work with JAWS

Reported by: Mangala Sadhu Sangeet Singh Khalsa Owned by: Colin Snover <github.com@…>
Priority: undecided Milestone: 1.8.7
Component: DojoX Grid Version: 1.9.3
Keywords: Cc:
Blocked By: Blocking:

Description

The IndirectSelection? plugin creates faux Dijits for radio buttons and checkboxes. The ARIA role attribute is specified using camel-case: https://github.com/dojo/dojox/blob/master/grid/enhanced/plugins/IndirectSelection.js#L91

The attribute is case-sensitive and must be lowercase. With the role attribute fixed, there is also redundancy between the aria-label value, which specifies the element role, and the role attribute. https://github.com/dojo/dojox/blob/master/grid/enhanced/nls/EnhancedGrid.js#L10

Change History (7)

comment:1 Changed 6 years ago by Mangala Sadhu Sangeet Singh Khalsa

I linked to the NLS file that needs to be fixed in my description, but for clarity's sake this is where the NLS values are referenced: https://github.com/dojo/dojox/blob/master/grid/enhanced/plugins/IndirectSelection.js#L92

comment:2 Changed 5 years ago by bill

Resolution: patchwelcome
Status: newclosed

DojoX Grid and EnhancedGrid? are deprecated in favor of dgrid and gridx.

You should upgrade your code to use one of those two grids.

We will consider patches to the old DojoX Grid code though.

comment:3 Changed 5 years ago by Colin Snover <github.com@…>

Owner: set to Colin Snover <github.com@…>
Resolution: patchwelcomefixed

In e8e091710033159656f0e1dab0dfc8db577f5b7a/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:4 Changed 5 years ago by Colin Snover <github.com@…>

In 66102d126327185a94bd9c3154d56494552f23fe/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:5 Changed 5 years ago by Colin Snover <github.com@…>

In aded6105f1efe4517142ffd3794f9b304a46b0f4/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:6 Changed 5 years ago by Colin Snover <github.com@…>

In fe276c871060dc063b622f2234062189e7b86b21/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:7 Changed 5 years ago by Colin Snover

Milestone: tbd1.8.7
Note: See TracTickets for help on using tickets.