Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#17753 closed defect (fixed)

Deferred instrumentation stops working after a default build

Reported by: Colin Snover Owned by: Colin Snover
Priority: high Milestone: 1.9.4
Component: BuildSystem Version: 1.9.3
Keywords: Cc: Rawld Gill
Blocked By: Blocking:

Description

config-useDeferredInstrumentation is only specified in the default configuration in dojo.js. The default configuration is removed after a normal build by replaceLoaderConfig. As a result, built versions of Dojo act differently than unbuilt versions. The code for instrumentation is not optimised out, so there is no size benefit to doing this. In order to not be confusing, it ought to work the same way after a build as it did before a build.

There are two possibilities:

  1. Add the default configuration value in buildControlDefault
  2. Set the default configuration with a has.add rule instead that won’t be destroyed if someone hasn’t tried to build with a fixed value for useDeferredInstrumentation.

I am not sure which is better. I have never seen anyone set useDeferredInstrumentation to something other than the default in practice.

Change History (3)

comment:1 Changed 5 years ago by Colin Snover <github.com@…>

Resolution: fixed
Status: newclosed

In 84f97f29f6cf40c514550c437caee83f40d0fc6a/dojo:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:1 Changed 5 years ago by Colin Snover <github.com@…>

Resolution: fixed
Status: newclosed

In 5b28811930e9353160fe7f0a9680615e3da98639/dojo:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:2 Changed 5 years ago by Colin Snover <github.com@…>

In fdcc15e86445ea8b893ef65d29b860ef12a2abb3/dojo:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 
Note: See TracTickets for help on using tickets.