use native placeholder support for form inputs

[liucougar]

if browser natively supports placeholder in input (and alike), use the native support instead

[bill]

I figured we'd drop the custom placeholder code for 2.0, when all our supported platforms have native placeholder support... except IE9, that would have "graceful degradation". Is there a reason to branch the behavior (in 1.x)?

[liucougar]

we are seeing some problems with the custom placeholder when it's used in auto-complete input in a dialog: even if they are filled by browser autocomplete, the custom placeholder still show up

i could not find a way to fix the custom placeholder implementation

[bill]

OK, fair enough.

The tests need to be updated though; IE8 is getting failures in ValidationTextBox?, ComboBox? and FilteringSelect? (the last two are actually from the same test file). I'm confused why that happens since IE8 doesn't have native placeholder support.

Thanks.

[liucougar]

updated patch

[liucougar]

Attachment (17751.patch) added by ticket reporter.

[liucougar]

updated patch

[liucougar]

i believe the error is caused by bidi support (I forgot to include a change in the original patch)

could you try the updated patch? I believe it will work fine in IE8. thanks

[bill]

It still fails. The failing tests are not BIDI tests, they are plain LTR tests.

[liucougar]

updated patch with test fixes

[liucougar]

Attachment (17751.3.patch) added by ticket reporter.

[liucougar]

the attached patch fixes a bug in the original patch, and it also modifies tests so they won't fail when placeholder is natively supported

[Heng Liu <[email protected]…>]

In 63486c0569d7ba60e351cf01f36dd8f007ed3b48/dijit:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

[Colin Snover <[email protected]…>]

In 6e60fb4aa317146fa86f44ee36a725131e5470ba/dijit:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

[Colin Snover]

As per Dojo meeting discussion, 63486c05 was reverted due to its impact on backcompat. The issue with autocomplete not allowing placeholders to be hidden should be opened and tracked in a different defect ticket.