Opened 7 years ago
Closed 6 years ago
#17751 closed enhancement (wontfix)
use native placeholder support for form inputs
Reported by: | liucougar | Owned by: | liucougar |
---|---|---|---|
Priority: | undecided | Milestone: | tbd |
Component: | Dijit - Form | Version: | 1.9.3 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
if browser natively supports placeholder in input (and alike), use the native support instead
Attachments (3)
Change History (16)
comment:1 Changed 7 years ago by
Component: | General → Dijit - Form |
---|
comment:3 Changed 7 years ago by
we are seeing some problems with the custom placeholder when it's used in auto-complete input in a dialog: even if they are filled by browser autocomplete, the custom placeholder still show up
i could not find a way to fix the custom placeholder implementation
comment:4 Changed 7 years ago by
Owner: | set to liucougar |
---|---|
Status: | new → pending |
OK, fair enough.
The tests need to be updated though; IE8 is getting failures in ValidationTextBox?, ComboBox? and FilteringSelect? (the last two are actually from the same test file). I'm confused why that happens since IE8 doesn't have native placeholder support.
Thanks.
comment:5 Changed 7 years ago by
Status: | pending → new |
---|
Attachment (17751.patch) added by ticket reporter.
comment:6 Changed 7 years ago by
i believe the error is caused by bidi support (I forgot to include a change in the original patch)
could you try the updated patch? I believe it will work fine in IE8. thanks
comment:7 Changed 7 years ago by
Status: | new → pending |
---|
It still fails. The failing tests are not BIDI tests, they are plain LTR tests.
comment:8 Changed 7 years ago by
Status: | pending → new |
---|
Attachment (17751.3.patch) added by ticket reporter.
comment:9 Changed 7 years ago by
the attached patch fixes a bug in the original patch, and it also modifies tests so they won't fail when placeholder is natively supported
comment:10 Changed 7 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:12 Changed 7 years ago by
Resolution: | fixed |
---|---|
Status: | closed → reopened |
As per Dojo meeting discussion, 63486c05 was reverted due to its impact on backcompat. The issue with autocomplete not allowing placeholders to be hidden should be opened and tracked in a different defect ticket.
comment:13 Changed 6 years ago by
Resolution: | → wontfix |
---|---|
Status: | reopened → closed |
I figured we'd drop the custom placeholder code for 2.0, when all our supported platforms have native placeholder support... except IE9, that would have "graceful degradation". Is there a reason to branch the behavior (in 1.x)?