Opened 5 years ago

Closed 5 years ago

#17723 closed defect (invalid)

_ComboBoxMenuMixin

Reported by: pinguxx Owned by: pinguxx
Priority: undecided Milestone: tbd
Component: Dijit - Form Version: 1.9.1
Keywords: Cc:
Blocked By: Blocking:

Description

When using pageSize in a dijit/form/FilteringSelect in a declarative format i end up with a too much recursion problem, i found out that

Line 126 to 130:

// Try to determine if we should show 'more'...
if(results.total && !results.total.then && results.total != -1){
				if((options.start + options.count) < results.total){
					displayMore = true;
				}else if((options.start + options.count) > results.total && options.count == results.length){

Checks are not correct and its causing a too much recursion problem later on while trying to select the next valid option in an empty list (only previos options showed) adding a '+' to the options.count should fix that by converting the count to a number and not concatenate string

// Try to determine if we should show 'more'...
if(results.total && !results.total.then && results.total != -1){
				if((options.start + +options.count) < results.total){
					displayMore = true;
				}else if((options.start + +options.count) > results.total && options.count == results.length){

Or any other fix that make the count number and not string

Change History (2)

comment:1 Changed 5 years ago by bill

Owner: set to pinguxx
Status: newpending

AFAIK options.count is a number already. Can you give a test file where this is failing?

comment:2 Changed 5 years ago by trac-o-bot

Resolution: invalid
Status: pendingclosed

Because we get so many tickets, we often need to return them to the initial reporter for more information. If that person does not reply within 14 days, the ticket will automatically be closed, and that has happened in this case. If you still are interested in pursuing this issue, feel free to add a comment with the requested information and we will be happy to reopen the ticket if it is still valid. Thanks!

Note: See TracTickets for help on using tickets.