Opened 7 years ago
Closed 6 years ago
#17721 closed defect (invalid)
Dijit mirroring defects
Reported by: | Owned by: | bill | |
---|---|---|---|
Priority: | high | Milestone: | 1.11 |
Component: | Dijit | Version: | 1.9.2 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
Fixing the following mirroring defects in Dojo widgets:
InlineEditBox?: Vertical bar in dijit.InlineEditBox? ComboBox?: Vertical bar in dijit.form.ComboBox? popup: Vertical Bar Progressbar: Problem with Indeterminate Progress bar InlineEditBox?: The programmatically created dijit.InlineEditBox? is not mirrored when activated ComboBox?: Wrong display of mirrored dijit.form.ComboBox? when text is longer than its width SplitContainer?: Wrong mirroring of dijit.layout.ContentPane? Tree (ForestStoreModel?): The programmatically created dijit.Tree is not mirrored correctly when dir is specified on widget level Menu, MenuItem?: Wrong place of the arrow of the mirrored dijit.PopupMenuItem? Menu, MenuItem?: Problem with mirrored dijit.CheckedMenuItem? Menu, MenuItem?: Wrong place of the icom of the mirrored dijit.PopupMenuItem? Menu, MenuItem?: Wrong display of mirrored dijit.PopupMenuItem? with shortcut StackContainer?: Wrong display of mirrored dijit.layout.StackContainer? when dir is specified on widget level Menu: Text Alignment ComboBox?: Menu Position InlineEditBox?: Menu Position
Attachments (5)
Change History (13)
Changed 7 years ago by
Attachment: | mirroring.defects.patch added |
---|
Changed 7 years ago by
Attachment: | dijit.widgets.rtl.tests.zip added |
---|
Changed 7 years ago by
Attachment: | sample.jpg added |
---|
comment:1 Changed 7 years ago by
Milestone: | tbd → 1.10 |
---|---|
Owner: | set to bill |
Priority: | undecided → high |
Status: | new → assigned |
comment:2 Changed 7 years ago by
comment:4 Changed 7 years ago by
Please find below our responses for each of your comments:
- We modified the comment in the two files to be "change widget orientation"
- These two fixes are for fixing the "ctrl+shift" behavior. Without these fixes, Ctrl+Shift does not change the position of the cursor as expected.
- The automated test file is: _BidiSupport/mirroring/test_Editor.html
- Done in Menu_rtl.less and ProgressBar_rtl.less
- The code in _WidgetBase.js is for handling programmatic creation of the widget with the dir attribute in the div.
If we do not write dir attribute during programmatic creation and put the dir attribute only on the div, the widget will not be affected without this fix. Please refer to item3wrong and item3expecetd in the attached images.
- We set the dir of the "editorWrapper" with this.domNode.dir. To handle the case where for example Body is LTR and Widget is RTL.
For example, before Editing the widget is RTL as expected, but after editing it becomes LTR which is wrong. After the fix, the widget will be RTL before and after editing as expected. Please refer to item4beforefix and item4afterfix in the attached images, each of them has the initial widget in the above half and the widget after editing in the bottom half.
- Modifications are done in MenuItem?.js
- I changed the method from postCreate() to startup()
- I added "dojo/dom-construct" at the top of the file.
- Yes this fix is to support a dir=rtl MenuItem? inside a dir=ltr Menu and Yes I think the arrow and icon should be in a different direction from the other MenuItems?, please refer to item5 in the attached images.
- The code in popup.js is for Vertical bar and popup position. Please refer to item6wrong and item6expecetd in the attached images.
- There is only 1 test file for ComboBox?.
There is only one test file per widget and they are used also for automated testing
- Done in SplitContainer?.js
- Done in SplitContainer?.js and DropDownMenu?.js
- Done in StackController?.js
comment:5 Changed 7 years ago by
OK, thanks, but again, you've made a lot of changes, so what I'd like you to do is to resubmit them as a series github pull request against the latest code in https://github.com/dojo/dijit, one pull request per widget (except the Menu and MenuItem? changes can be combined), and one for the popup change.
comment:8 Changed 6 years ago by
Resolution: | → invalid |
---|---|
Status: | assigned → closed |
I'm closing this meta-ticket since I never got the PR's as I requested. Please open individual tickets for any remaining issues that you still want to fix.
Pasting my notes from email before they get lost:
You've made a lot of changes, so what I'd like you to do is to resubmit them as a series github pull request against the latest code in https://github.com/dojo/dijit, one pull request per widget (except the Menu and MenuItem? changes can be combined), and one for the popup change. Each pull request should explain what the change is for. For example, the ProgressBar? pull request should say something like "reverse direction of indeterminate progress bar animation, to sweep from right to left in RTL mode", instead of just "Problem with Indeterminate Progress bar" like you wrote here.
Normally I write feedback in github, as responses to the pull requests, but I'll give some initial feedback now. You can address these questions in the individual pull requests for each file.
These sound like enhancements rather than defects, but anyway I need some explanation about what they are for. When you make the pull requests for Editor and TextBox?, please explain what you are enhancing, and include automated tests.
Regarding formatting: