dojox/gfx/path#_updateWithSegment may produce a stack overflow with large path arrays

[Mangala Sadhu Sangeet Singh Khalsa]

Line 214 in path.js uses Array.prototype.push.apply to concatenate two arrays: Array.prototype.push.apply(this.shape.path, path);

If the "path" array is large this will cause a stack overflow: ​https://code.google.com/p/v8/issues/detail?id=2896 ​https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Function/apply#Using_apply_and_built-in_functions

The attached patch file uses a for loop to push each element individually.

[cjolif]

Thank mkgalsa,

The fix is trivial but I think it would be good if you had a Dojo CLA anyway. Do you have one (I can't find your nickname on the CLA listing)?

cf: ​http://dojofoundation.org/about/claForm

[Bryan Forbes]

His contribution is covered by SitePen?'s CCLA.

[Eric Durocher]

Fixed in Git commit: ​https://github.com/dojo/dojox/commit/67486ca03ed13a8827171c4dba0f5f77d0bd6f4c

[Colin Snover]

Backport backport backport backport backport backport backport backport backport backport backport backport backport. How many more times do I need to drive this point home? I have talked about it on the mailing list, I have talked about it on commits, I have talked about it in the bug tracker. Please, BACKPORT FIXES WHEN YOU COMMIT THEM.

[Eric Durocher]

done done done ;) in 1.9/8/7 (Thanks for the reminder.)

[Colin Snover]

Thank you!!