Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#17683 closed feature (fixed)

Add ios7 theme

Reported by: Patrick Ruzand Owned by: Damien Mandrioli
Priority: blocker Milestone: 1.10
Component: DojoX Mobile Version: 1.9.2
Keywords: ios7 Cc: cjolif, Patrick Ruzand
Blocked By: Blocking:

Description


Change History (8)

comment:1 Changed 6 years ago by Patrick Ruzand

Cc: cjolif Patrick Ruzand added
Keywords: ios7 added
Milestone: tbd → 1.10
Owner: set to Damien Mandrioli
Priority: undecided → blocker
Status: new → assigned

Add new ios7 dojo mobile theme.

comment:4 Changed 5 years ago by Damien Mandrioli

Resolution: → fixed
Status: assigned → closed

comment:5 Changed 5 years ago by Adrian Vasiliu <vasiliu@…>

In 03ff3a12d1f96db6eca649d4eaa0219d947beb31/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?

comment:6 Changed 5 years ago by Adrian Vasiliu

So here's what happened: a week before the merge of the PR, the less file of ComboBox? has changed (for #17821, in commit ​https://github.com/dojo/dojox/commit/5429d720e198f49e0d2d35ed1430803bd6aa67f9). Hence the generated .css included in the PR wasn't anymore consistent with the latest state of the less file in the repository. Fixed by committing the regenerated css.

comment:7 Changed 5 years ago by Damien Mandrioli

Apply ios7 theme to iOS7 devices by default. ​https://github.com/dojo/dojox/commit/879ebdfc8c13df1758bcecc053d77394a2582768

comment:8 Changed 5 years ago by Adrian Vasiliu

Would be nice to update dojox/mobile/tests/test_theme-switch.html to include the new theme.

Note: See TracTickets for help on using tickets.