Opened 6 years ago

Closed 5 years ago

#17682 closed enhancement (fixed)

dojox/mobile/ListItem variable height layout on resize() has negative impact on performances.

Reported by: Sebastien Pereira Owned by: Sebastien Pereira
Priority: high Milestone: 1.10
Component: DojoX Mobile Version: 1.9.2
Keywords: Cc: Patrick Ruzand
Blocked By: Blocking:

Description

On desktop browsers resize() is called when the window size changes. On mobile browsers resize() is called when the orientation changes. In both case resize() allows to lay out widgets according to the new window/container dimensions, and all ListItem? resize() from all defined Views are called synchronously.

When CSS class mblVariableHeight and/or ListItem? property variableHeight is enforced, a call to resize() causes the current item to lay out in function layoutVariableHeight(), which has a negative impact on perfomance. Also, resizing ends up with a new ListItem? width but ListItem? height doesn't change.

This ticket proposes to remove this code from ListItem?.resize()

if(this.variableHeight){
 this.layoutVariableHeight();
}

Change History (5)

comment:1 Changed 6 years ago by Sebastien Pereira

Cc: Patrick Ruzand added
Owner: set to Sebastien Pereira
Status: newassigned

comment:2 Changed 6 years ago by Sebastien Pereira

Milestone: tbd1.10

comment:3 Changed 6 years ago by Patrick Ruzand

Priority: undecidedhigh

comment:5 Changed 5 years ago by Patrick Ruzand <pruzand@…>

Resolution: fixed
Status: assignedclosed

In e6bc684b87b8933783cd339af4538c4a67a8f23a/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 
Note: See TracTickets for help on using tickets.