Opened 7 years ago
Closed 7 years ago
#17679 closed enhancement (fixed)
[patch][cla] stop animation when anim.destroy is called
Reported by: | iDo | Owned by: | bpayton |
---|---|---|---|
Priority: | high | Milestone: | 1.10 |
Component: | fx | Version: | 1.9.2 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
I noticed that chained animations have a destroy function while single animations does not. As both are animations, it would be nicer to have the same API. I propose to add destroy() on all animations.
Additionally, animations should be stopped when a widget is destroyed. Else, the animation may throw an error because the domNode doe not exist anymore. I propose to do an anim.stop() in the destroy of the animation.
Thanks to both changes, we can use own() to handle the destroy/stop of the animation.
See https://github.com/dojo/dojo/pull/53 for changes
Change History (4)
comment:1 Changed 7 years ago by
comment:2 Changed 7 years ago by
Summary: | stop animation when anim.destroy is called → [patch][cla] stop animation when anim.destroy is called |
---|
comment:3 Changed 7 years ago by
Milestone: | tbd → 1.10 |
---|---|
Owner: | set to bpayton |
Priority: | undecided → high |
Status: | new → assigned |
comment:4 Changed 7 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Note: See
TracTickets for help on using
tickets.
Forgot to mention [CLA] in the title :/