Opened 6 years ago

Closed 6 years ago

#17679 closed enhancement (fixed)

[patch][cla] stop animation when anim.destroy is called

Reported by: iDo Owned by: bpayton
Priority: high Milestone: 1.10
Component: fx Version: 1.9.2
Keywords: Cc:
Blocked By: Blocking:

Description

I noticed that chained animations have a destroy function while single animations does not. As both are animations, it would be nicer to have the same API. I propose to add destroy() on all animations.

Additionally, animations should be stopped when a widget is destroyed. Else, the animation may throw an error because the domNode doe not exist anymore. I propose to do an anim.stop() in the destroy of the animation.

Thanks to both changes, we can use own() to handle the destroy/stop of the animation.

See ​https://github.com/dojo/dojo/pull/53 for changes

Change History (4)

comment:1 Changed 6 years ago by iDo

Forgot to mention [CLA] in the title :/

comment:2 Changed 6 years ago by dylan

Summary: stop animation when anim.destroy is called → [patch][cla] stop animation when anim.destroy is called

comment:3 Changed 6 years ago by dylan

Milestone: tbd → 1.10
Owner: set to bpayton
Priority: undecided → high
Status: new → assigned

comment:4 Changed 6 years ago by Bill Keese <bill@…>

Resolution: → fixed
Status: assigned → closed

In f6b183727946a454db0e8dc421e927a051cce57b/dojo:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?
Note: See TracTickets for help on using tickets.