Opened 5 years ago

Closed 5 years ago

#17672 closed defect (fixed)

Claro - menu item outline is corrupted in IE8

Reported by: Mangala Sadhu Sangeet Singh Khalsa Owned by: bill
Priority: undecided Milestone: 1.10
Component: Dijit Version: 1.7.5
Keywords: Cc:
Blocked By: Blocking:

Description

In IE8 on Windows XP, menu items have an outline when selected. The table cell containing the label (dijitMenuItemLabel) does not display the outline - the difference between it and the neighboring cells, which do display the outline, seems to be that position:relative is applied to the label.

This can be seen in "dijit/tests/test_Menu.html" and in the attached image.

Adding a rule in dijit.css to over-ride the position fixes the issue:

.dj_ie8 .dijitMenuItemLabel {
	position: static;
}

I'm not sure in what cases it might be important to have position set to relative, but for the test page I don't see any ill effects from setting it to static.

Attachments (2)

Dijit-1.7-MenuItemHover-IE8.png (59.2 KB) - added by Mangala Sadhu Sangeet Singh Khalsa 5 years ago.
Dijit-1.9-MenuItemHover-IE8.png (59.0 KB) - added by Mangala Sadhu Sangeet Singh Khalsa 5 years ago.

Download all attachments as: .zip

Change History (5)

Changed 5 years ago by Mangala Sadhu Sangeet Singh Khalsa

comment:1 Changed 5 years ago by Mangala Sadhu Sangeet Singh Khalsa

Claro in Dojo 1.8 has no outline or border on menu items.

In 1.9, there is a border, which is also corrupted in IE8. The same fix applies - remove relative positioning.

Changed 5 years ago by Mangala Sadhu Sangeet Singh Khalsa

comment:2 Changed 5 years ago by bill

Milestone: tbd1.10
Owner: set to bill
Status: newassigned

The relative positioning was added in 1242302c57152f17504d268a944e5dea19d542b7 but without any explanation. Indeed, it seems like it should be removed.

comment:3 Changed 5 years ago by Bill Keese <bill@…>

Resolution: fixed
Status: assignedclosed

In add4d81ca7d71d1ab13f2bf542f4577762e6cb47/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 
Note: See TracTickets for help on using tickets.