Opened 9 years ago
Closed 8 years ago
#17653 closed feature (fixed)
support textdir= attribute for Editor
Reported by: | bill | Owned by: | bill |
---|---|---|---|
Priority: | undecided | Milestone: | 1.10 |
Component: | Editor | Version: | 1.9.2 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
This is to set the text direction, as opposed to the layout of the buttons in the toolbar. See https://github.com/dojo/dijit/pull/15.
Change History (5)
comment:1 Changed 9 years ago by
Owner: | set to Bill Keese <[email protected]…> |
---|---|
Resolution: | → fixed |
Status: | new → closed |
comment:2 Changed 8 years ago by
Milestone: | tbd → 1.10 |
---|
comment:3 Changed 8 years ago by
Resolution: | fixed |
---|---|
Status: | closed → reopened |
This completely breaks the ToggleDir? plugin. Clicking the button has no effect. Not sure why the regression test doesn't catch it.
comment:4 Changed 8 years ago by
Owner: | changed from Bill Keese <[email protected]…> to bill |
---|---|
Status: | reopened → assigned |
comment:5 Changed 8 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
In 86cd0479595d25478e67ead1128c3d23ef6c0e85/dijit:
Redo Editor textDir support and TogglePlugin? to work together.
Also fixed a bug where Editor toolbar buttons were being created with weird names like "dijit/editor/_plugins/ToggleTextDir". On IE that was causing Editor to think that the <input> was the plugin.
Finally, cleaned up the tests to remove code duplication. The tests could still be much better, for example checking the button state (checked or not) and checking the computed direction of the editor text rather than directly checking the dir attribute.
In 0e535339c4baf60630e718e09cd8d49ec7069f22/dijit: