Opened 7 years ago
Last modified 3 years ago
#17652 reopened defect
[regression] z-axis vectors disabled in dojox/drawing
Reported by: | Brett van de Sande | Owned by: | liucougar |
---|---|---|---|
Priority: | undecided | Milestone: | 1.14 |
Component: | DojoX Drawing | Version: | 1.9.2 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
During the conversion of dojox.drawing to AMD, the z-axis vector button (vectorSecondary) was not converted. Instead, it was commented out. See commit dcb1f0ca39e56c6be4c0986863f828ed44fe1b8a
Attachments (1)
Change History (7)
comment:1 Changed 7 years ago by
Owner: | set to liucougar |
---|---|
Status: | new → assigned |
Summary: | z-axis vectors disabled in dojox/drawing → [regression] z-axis vectors disabled in dojox/drawing |
Changed 7 years ago by
Attachment: | Vector.js-patch added |
---|
comment:2 Changed 7 years ago by
I think I have the Z-axis vectors working again. See the attached patch file.
You can test the patch using dojox/drawing/tests/test_drawing.html
.
Note that the commit dcb1f0ca39e56c6be4c0986863f828ed44fe1b8a incorrectly
changed this.util.angle
to positioning.angle
. These are not the same function.
comment:3 Changed 5 years ago by
Milestone: | tbd → 1.12 |
---|---|
Resolution: | → patchwelcome |
Status: | assigned → closed |
Given the lack of attention to dojox/drawing, we would accept a pull request to fix this issue, otherwise it's probably not going to get done. Closing as patchwelcome, feel free to reopen if you want to contribute a fix!
comment:4 Changed 4 years ago by
Added pull request https://github.com/dojo/dojox/pull/275 Please re-open this bug.
comment:5 Changed 4 years ago by
Resolution: | patchwelcome |
---|---|
Status: | closed → reopened |
comment:6 Changed 3 years ago by
Milestone: | 1.13 → 1.14 |
---|
Patch file for dojox/drawing/tools/custom/Vector.js