Opened 5 years ago

Last modified 20 months ago

#17652 reopened defect

[regression] z-axis vectors disabled in dojox/drawing

Reported by: Brett van de Sande Owned by: liucougar
Priority: undecided Milestone: 1.14
Component: DojoX Drawing Version: 1.9.2
Keywords: Cc:
Blocked By: Blocking:


During the conversion of dojox.drawing to AMD, the z-axis vector button (vectorSecondary) was not converted. Instead, it was commented out. See commit dcb1f0ca39e56c6be4c0986863f828ed44fe1b8a

Attachments (1)

Vector.js-patch (4.4 KB) - added by Brett van de Sande 5 years ago.
Patch file for dojox/drawing/tools/custom/Vector.js

Download all attachments as: .zip

Change History (7)

comment:1 Changed 5 years ago by bill

Owner: set to liucougar
Status: newassigned
Summary: z-axis vectors disabled in dojox/drawing[regression] z-axis vectors disabled in dojox/drawing

Changed 5 years ago by Brett van de Sande

Attachment: Vector.js-patch added

Patch file for dojox/drawing/tools/custom/Vector.js

comment:2 Changed 5 years ago by Brett van de Sande

I think I have the Z-axis vectors working again. See the attached patch file. You can test the patch using dojox/drawing/tests/test_drawing.html.

Note that the commit dcb1f0ca39e56c6be4c0986863f828ed44fe1b8a incorrectly changed this.util.angle to positioning.angle. These are not the same function.

comment:3 Changed 3 years ago by dylan

Milestone: tbd1.12
Resolution: patchwelcome
Status: assignedclosed

Given the lack of attention to dojox/drawing, we would accept a pull request to fix this issue, otherwise it's probably not going to get done. Closing as patchwelcome, feel free to reopen if you want to contribute a fix!

comment:4 Changed 23 months ago by Brett van de Sande

Added pull request Please re-open this bug.

comment:5 Changed 23 months ago by dylan

Resolution: patchwelcome
Status: closedreopened

comment:6 Changed 20 months ago by dylan

Milestone: 1.131.14
Note: See TracTickets for help on using tickets.