Opened 4 years ago
Last modified 2 months ago
#17652 reopened defect
[regression] z-axis vectors disabled in dojox/drawing
| Reported by: | glueball | Owned by: | liucougar |
|---|---|---|---|
| Priority: | undecided | Milestone: | 1.13 |
| Component: | DojoX Drawing | Version: | 1.9.2 |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
During the conversion of dojox.drawing to AMD, the z-axis vector button (vectorSecondary) was not converted. Instead, it was commented out. See commit dcb1f0ca39e56c6be4c0986863f828ed44fe1b8a
Attachments (1)
Change History (6)
comment:1 Changed 4 years ago by bill
- Owner set to liucougar
- Status changed from new to assigned
- Summary changed from z-axis vectors disabled in dojox/drawing to [regression] z-axis vectors disabled in dojox/drawing
Changed 4 years ago by glueball
comment:2 Changed 4 years ago by glueball
I think I have the Z-axis vectors working again. See the attached patch file. You can test the patch using dojox/drawing/tests/test_drawing.html.
Note that the commit dcb1f0ca39e56c6be4c0986863f828ed44fe1b8a incorrectly changed this.util.angle to positioning.angle. These are not the same function.
comment:3 Changed 21 months ago by dylan
- Milestone changed from tbd to 1.12
- Resolution set to patchwelcome
- Status changed from assigned to closed
Given the lack of attention to dojox/drawing, we would accept a pull request to fix this issue, otherwise it's probably not going to get done. Closing as patchwelcome, feel free to reopen if you want to contribute a fix!
comment:4 Changed 2 months ago by glueball
Added pull request https://github.com/dojo/dojox/pull/275 Please re-open this bug.
comment:5 Changed 2 months ago by dylan
- Resolution patchwelcome deleted
- Status changed from closed to reopened
Patch file for dojox/drawing/tools/custom/Vector.js