Opened 6 years ago

Closed 6 years ago

#17651 closed defect (fixed)

[patch][cla] dojo/router.destroy errors if startup not called

Reported by: dylan Owned by: dylan
Priority: undecided Milestone: 1.9.3
Component: Core Version: 1.9.2
Keywords: Cc:
Blocked By: Blocking:

Description

With dojo/router, if you attempt to call router.destroy() before calling router.startup(), an exception is thrown.

I found this issue in working on converting the DOH tests to use Intern.

  1. Should this be fixed?
  2. If so, perhaps something as simple as

if (!this._started) { return false; }

inside of router.destroy?

Change History (4)

comment:1 Changed 6 years ago by dylan

Summary: dojo/router.destroy errors if startup not called[patch][cla] dojo/router.destroy errors if startup not called

https://github.com/dojo/dojo/pull/51/

Would appreciate a sanity check.

comment:2 Changed 6 years ago by dylans <dylan@…>

In 36a2a4e94c3dc9c758749dae01fd7f6b089e9e5a/dojo:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:3 Changed 6 years ago by dylans <dylan@…>

In 11000350c913d629ab0ee5e901ad2fa0b7ff7df4/dojo:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:4 Changed 6 years ago by dylan

Milestone: tbd1.9.3
Resolution: fixed
Status: newclosed

Backported to 1.9.

1.8 does not have a destroy method in RouterBase?, so no further backporting will be done.

Note: See TracTickets for help on using tickets.