Opened 7 years ago
Closed 7 years ago
#17651 closed defect (fixed)
[patch][cla] dojo/router.destroy errors if startup not called
Reported by: | dylan | Owned by: | dylan |
---|---|---|---|
Priority: | undecided | Milestone: | 1.9.3 |
Component: | Core | Version: | 1.9.2 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
With dojo/router, if you attempt to call router.destroy() before calling router.startup(), an exception is thrown.
I found this issue in working on converting the DOH tests to use Intern.
- Should this be fixed?
- If so, perhaps something as simple as
if (!this._started) { return false; }
inside of router.destroy?
Change History (4)
comment:1 Changed 7 years ago by
Summary: | dojo/router.destroy errors if startup not called → [patch][cla] dojo/router.destroy errors if startup not called |
---|
comment:4 Changed 7 years ago by
Milestone: | tbd → 1.9.3 |
---|---|
Resolution: | → fixed |
Status: | new → closed |
Backported to 1.9.
1.8 does not have a destroy method in RouterBase?, so no further backporting will be done.
Note: See
TracTickets for help on using
tickets.
https://github.com/dojo/dojo/pull/51/
Would appreciate a sanity check.