Opened 7 years ago
Closed 7 years ago
#17643 closed enhancement (fixed)
[CLA] [PATCH] Allow developers to construct their own "cachebusted" url
Reported by: | iDo | Owned by: | bpayton |
---|---|---|---|
Priority: | low | Milestone: | 1.10 |
Component: | Loader | Version: | 1.9.2 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
Hi all, The idea is to provide a way to construct the cachebusted URL. For instance, in our project we have multiple components, but all based on the same dojo instance. We need to have a different version number appended to URL according to the component currently running. This way, we can release one component without have to clear the cache of all other components.
With the attached patch, we can define a custom fixupUrl function in dojoConfig.
Attachments (1)
Change History (7)
Changed 7 years ago by
Attachment: | fixupUrl.patch added |
---|
comment:1 follow-up: 2 Changed 7 years ago by
Patch looks fine. Adding a test would be nice.
Can you create a pull request for this? https://github.com/dojo/dojo/blob/master/CONTRIBUTING.md#submitting-a-pull-request
comment:2 Changed 7 years ago by
Replying to dylan:
Patch looks fine. Adding a test would be nice.
Can you create a pull request for this? https://github.com/dojo/dojo/blob/master/CONTRIBUTING.md#submitting-a-pull-request
Hi, I tried to create a test but userConfig seems to not point to dojo.config. Therefore it's kind of static. The only way I found was to change the config used by doh, but it's not really satisfying. Any idea?
Note: Pull request is sent
Ben
comment:4 Changed 7 years ago by
Milestone: | tbd → 1.10 |
---|---|
Owner: | set to bpayton |
Priority: | undecided → low |
Status: | new → assigned |
comment:5 Changed 7 years ago by
Looking forward to 1.10, this enhancement is very important for our deployments.
comment:6 Changed 7 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
patch for dojo.js