Opened 5 years ago

Closed 3 years ago

#17630 closed defect (patchwelcome)

LightboxDialog hide function fades twice

Reported by: Yasir Assam Owned by:
Priority: undecided Milestone: 1.13
Component: Dojox Version: 1.9.2
Keywords: Cc:
Blocked By: Blocking:

Description

dojox.image.LightboxDialog?.hide() fades this.titleNode, but it then calls this.inherited(), which calls dijit.Dialog.hide(), which in turn fades this.domNode

It's not clear why we need two different fades (perhaps Lightbox.hide() was written when Dialog.hide() didn't fade?)

The fade durations are different.

It's possible to intercept the end of the fade for Dialog.hide() (because it emits an onHide event), but it's not possible to know when the fade in dojox.image.LightboxDialog?.hide() ends. This means that if I call Dialog.destroy() when onHide is emited, and the Lightbox fade hasn't ended, then fade onEnd function will refer to this which will no longer exist.

Change History (1)

comment:1 Changed 3 years ago by dylan

Milestone: tbd1.12
Resolution: patchwelcome
Status: newclosed

Given that no one has shown interest in creating a patch in the past 2+ years, I'm closing this as patchwelcome. Please let us know if you would like to get involved in helping make this change to Dojo!

Note: See TracTickets for help on using tickets.