RadioButton: on(rb, "click", cb) fires before old RadioButton unchecked

[Mangala Sadhu Sangeet Singh Khalsa]

There is a brief window of time wherein more than one RadioButton? element (in the same named group) can be checked. During the processing of the 'click' event the clicked element is checked, but the previously checked element is also still checked.

See attached example to compare DOM and Dijit behavior.

[bill]

OK... so your code for listening to click events on the widgets is:

on(dijit1, 'click', logDijitState);
on(dijit2, 'click', logDijitState);
on(dijit3, 'click', logDijitState);

That calls logDijitState earlier than we want. I note that this code works correctly:

on(dijit1.domNode, 'click', logDijitState);
on(dijit2.domNode, 'click', logDijitState);
on(dijit3.domNode, 'click', logDijitState);

I guess it's got something to do with when logDijitState() is called relative to when the browser executes its default action (to clear the other radio button).

In any case, I think this will be fixed for 2.0 when we implement widgets as custom elements

[Colin Snover]

​https://github.com/dojo/dijit/pull/63

[bill]

I looked at this some more today. The native behavior of radio buttons (and likely checkboxes) is really weird. My expectation was that

1. the onclick handler is called
2. if it *doesn't* call evt.preventDefault() then the radio button's checked property is set to true

but the actual behavior is:

1. the checked property is set to true
2. the onclick handler is called
3. if the onclick handler calls evt.preventDefault(), the checked property is reverted to false

The so-called preventDefault() method isn't preventing anything, but rather reverting what has already been done.

Anyway, I see that the PR is implementing that same behavior. I don't like it, but I guess it's good to match native behavior. So, probably I can accept it.

[Bill Keese <[email protected]…>]

In 6d17a2a7040d20712a0aa6cc29211ca9730d0909/dijit:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?