Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#17589 closed defect (fixed)

[Patch][cla] dojox.layout.ScrollPane

Reported by: youngho Owned by: dylan
Priority: low Milestone: 1.9.2
Component: DojoX Layout Version: 1.9.1
Keywords: Cc:
Blocked By: Blocking:

Description

when a first click in dojox.layout.scrollpane component, the set value is not number and it should be filtered also in order to prevent a splattering.

Attachments (1)

ScrollPane.patch (545 bytes) - added by youngho 5 years ago.

Download all attachments as: .zip

Change History (10)

Changed 5 years ago by youngho

Attachment: ScrollPane.patch added

comment:1 Changed 5 years ago by dylan

Component: GeneralDojoX Layout
Milestone: tbd1.10
Owner: set to dylan
Priority: undecidedlow
Status: newassigned
Summary: [Patch]dojox.layout.ScrollPane[Patch][cla] dojox.layout.ScrollPane

comment:2 Changed 5 years ago by dylan

Pull request at https://github.com/dojo/dojox/pull/54 , does anyone care to review?

comment:3 Changed 5 years ago by dylans <dylan@…>

In 175773056dcdfd2b93279ed235113f0ffb1ffc5e/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:4 Changed 5 years ago by Dylan Schiemann <dylan@…>

In 399a2d7d035b7ff0fe02bd1e642ded66a2181246/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:5 Changed 5 years ago by dylans <dylan@…>

In ed77c3ed9972cad7339c900b6da9564f627fbaac/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:6 Changed 5 years ago by dylans <dylan@…>

In 99906daf23cc205938016442bd1aabe5f687b335/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:7 Changed 5 years ago by dylan

Milestone: 1.101.9.2
Resolution: fixed
Status: assignedclosed

Merged this fix in master, 1.9, and 1.8. It's not a clean merge back to 1.7, so I'm not sure if we want to merge it back to that release or not?

comment:8 Changed 5 years ago by dylans <dylan@…>

In 6169b5747e2e98d1f07f4ffc23ce6b1ee1a7238b/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:9 Changed 5 years ago by dylans <dylan@…>

In 209ef31746e962ae2d74625e3e3641adb6177433/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 
Note: See TracTickets for help on using tickets.