Opened 6 years ago

Closed 6 years ago

#17573 closed defect (fixed)

dojox.mobile.Heading should delete its labelNodeLen variable when a new label is set.

Reported by: dg Owned by: Sebastien Brunot
Priority: undecided Milestone: 1.10
Component: DojoX Mobile Version: 1.9.1
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by Sebastien Brunot)

dojox.mobile.Heading should delete its labelNodeLen variable when a new label is set.

Otherwise the resize() function will use incorrect size.

Fix is simple, add "delete this.labelNodeLen;" to the label setter.

Change History (5)

comment:1 Changed 6 years ago by Patrick Ruzand

Milestone: tbd1.10
Owner: set to Patrick Ruzand
Status: newassigned

comment:2 Changed 6 years ago by Patrick Ruzand

Owner: changed from Patrick Ruzand to Sebastien Brunot

comment:3 Changed 6 years ago by Sebastien Brunot

Description: modified (diff)
Summary: dojox.mobile.Heading should delete its nodeLabelLen variable when a new label is set.dojox.mobile.Heading should delete its labelNodeLen variable when a new label is set.

comment:4 Changed 6 years ago by Sebastien Brunot

I've created a pull request for a fix of this issue: https://github.com/dojo/dojox/pull/72

comment:5 Changed 6 years ago by Patrick Ruzand <pruzand@…>

Resolution: fixed
Status: assignedclosed

In b81404d11a866fb565219ad5d22d2e9204b1a445/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 
Note: See TracTickets for help on using tickets.