Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#17571 closed defect (fixed)

Select Input Class Incorrectly Calculates padding

Reported by: JaeTea666 Owned by: bill
Priority: undecided Milestone: 1.9.2
Component: Dijit Version: 1.9.1
Keywords: Cc:
Blocked By: Blocking:

Description

If you change this variable

@textbox-padding: 8px; Padding for Textbox, Textarea, etc. 

.dj_gecko .claro .dijitTextBox .dijitInputInner,
.dj_webkit .claro .dijitTextBox .dijitInputInner {
	// Although we are theoretically only adding 1px to top/bottom, some browsers seem to pad inputs by 1px on left/right,
	// so compensate for that too.
	padding: @textbox-padding - 1px;
}

Should be 

.dj_gecko .claro .dijitTextBox .dijitInputInner,
.dj_webkit .claro .dijitTextBox .dijitInputInner {
	// Although we are theoretically only adding 1px to top/bottom, some browsers seem to pad inputs by 1px on left/right,
	// so compensate for that too.
	padding-left: @textbox-padding - 1px;
	padding-right: @textbox-padding - 1px;
}

Change History (4)

comment:1 Changed 9 years ago by bill

Milestone: tbd → 1.10
Owner: set to bill
Status: new → assigned

Thanks, that does seem to make things better (specifically that in themeTester.html there's no whitespace between the bottom of the arrow and the bottom border of the Select etc.

comment:2 Changed 9 years ago by bill

Milestone: 1.10 → 1.9.2

comment:3 Changed 9 years ago by Bill Keese <[email protected]…>

Resolution: → fixed
Status: assigned → closed

In 72561c2661318a48d43dd7dd0de3ccae19c26add/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?

comment:4 Changed 9 years ago by Bill Keese <[email protected]…>

In 2ec779c9f75fc399cb3883d05964fa3183b00ecf/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?
Note: See TracTickets for help on using tickets.