Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#17560 closed defect (fixed)

Editor focus not detected (FF)

Reported by: bill Owned by: Bill Keese <bill@…>
Priority: undecided Milestone: 1.7.6
Component: Editor Version: 1.9.1
Keywords: dohfail Cc:
Blocked By: Blocking:

Description (last modified by bill)

Focus manager detects when an editor gets focused by setting up listeners on the iframe. The problem is that on FF the focus event in the iframe is ignored because of this code in focus.js:

if(tag == "#document" || tag == "body"){ return; }

This is part of the cause of a failure in the "tabbing" test in Editor_a11y.html on FF after checking in #10415.

An alternate approach to fixing it though it to use the wrapper div in firefox, like in other browsers. The current code is:

if(has("ie") || has("webkit") || (!this.height && !has("mozilla"))){
        // In auto-expand mode, need a wrapper div for AlwaysShowToolbar plugin to correctly
        // expand/contract the editor as the content changes.
        html = "<div id='dijitEditorBody'></div>";
        setBodyId = false;
}else if(has("mozilla")){
        // workaround bug where can't select then delete text (until user types something
        // into the editor)... and/or issue where typing doesn't erase selected text
        this._cursorToStart = true;
        html = "&#160;";        // &nbsp;
}

Change History (7)

comment:1 Changed 5 years ago by bill

Component: DijitEditor
Description: modified (diff)

comment:2 Changed 5 years ago by bill

Description: modified (diff)
Keywords: dohfail added
Milestone: tbd1.10
Summary: Editor focus not detectedEditor focus not detected (FF)

comment:3 Changed 5 years ago by Bill Keese <bill@…>

Owner: set to Bill Keese <bill@…>
Resolution: fixed
Status: newclosed

In 0854ec27436ba935b09e29c0cfc2960656780070/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:4 Changed 5 years ago by Colin Snover <github.com@…>

In f7e337959c313ccfdeae8e26c629a48e60fa9ed0/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:5 Changed 5 years ago by mahays0 <mahays0@…>

In a443c8477ce0111edffe0977dbe5794380af1001/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:6 Changed 5 years ago by Bill Keese <bill@…>

In 85084afe0860604414984acf95fb5edcb84cad19/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:7 Changed 5 years ago by bill

Milestone: 1.101.7.6
Note: See TracTickets for help on using tickets.