idProperty in dojo/store/Memory can be lost

[rolf]

If a Memory store is created this way

		var myStore = new Memory({
		idProperty: "uniqueID",
		data: response
		});

the defined idProperty may be overwritten (set to undefined or some other value) by the setData function in Memory.js:

	setData: function(data){
		// summary:
		//		Sets the given data as the source for this store, and indexes it
		// data: Object[]
		//		An array of objects to use as the source of data.
		if(data.items){
			// just for convenience with the data format IFRS expects
			this.idProperty = data.identifier;
			data = this.data = data.items;
		}else{
			this.data = data;
		}
		this.index = {};
		for(var i = 0, l = data.length; i < l; i++){
			this.index[data[i][this.idProperty]] = i;
		}
	}

If the object data contains items but not identifier (or identifier is different from the idProperty sent to the constructor) the original idProperty will be replaced and identity-based access will be broken.

[freddefisk]

Just out of curiosity, when do you set the data to an object that has an items property but doesn't have the correct identifier property?

[rolf]

Retrieving data in items array form seems like a rather likely concept, and may have been used over a long time in various applications. Whatever the reason my point is that the configuration of a data store object that I have created shouldn't be subject to silent manipulation by incoming data from a source that I may or may not have control over.

[Kris Zyp <[email protected]…>]

In 5c86aadf89e576075dfb27898a7897112751edad/dojo:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

[Colin Snover]

Backports please?

[freddefisk]

Not sure if this is a valid use case, but the change will break code storing Array objects and using the idProperty to specify the first element (index 0) as the object id. Right?

[Colin Snover]

It depends on whether or not you also set idProperty to 0. If you are setting the idProperty of the store then it will be fine. The only way what you are suggesting would fail would be if you did not set idProperty but did set identifier to 0 in the return data. Of course, a more robust 'identifier' in data or data.identifier != null check could be used instead, if it’s worth it to do so.

[Brandon Payton <[email protected]…>]

In 12edacb6409ab5028a75001d5d9ba8c658516174/dojo:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

[Brandon Payton <[email protected]…>]

In 9ecce2c040bde3ca49c95bb5f2aabb5fe7f1b0ef/dojo:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?