Opened 5 years ago

Closed 5 years ago

#17556 closed defect (fixed)

Using "dojox/html/ext-dojo/style" breaks "dojox/layout/ResizeHandle"

Reported by: chris2m Owned by: nic
Priority: undecided Milestone: 1.7.6
Component: Dojox Version: 1.9.1
Keywords: Cc:
Blocked By: Blocking:

Description

The problem is caused when "dojox/html/ext-dojo/style" and "dojox/layout/ResizeHandle" are used on the same page.

Cause "dojox/html/ext-dojo/style" monkey patches the get and set methods of "dojox/html/ext-dojo/style". ResizeHandle? calls domStyle.get with three parameters e.g. domStyle.get(this.targetDomNode, 'width', style)) the patched method however expects only one or two arguments. As a result the ResizeHandle? breaks.

FIX To fixed the bug, the following lines in "dojox/html/ext-dojo/style" should be replaced:

// delete
return arguments.length == 2 ? sget(node, name) : sget(node);

// replace with
return sget.apply(this, arguments);

and the same for the setter method:

// delete
return arguments.length == 3 ? sset(n, name, value) : sset(n, name);

// replace with
return sset.apply(this, arguments);

Change History (6)

comment:1 Changed 5 years ago by nic

Owner: set to nic
Status: newassigned

comment:2 Changed 5 years ago by Nicola Rizzo <nicola.rizzo@…>

In 701d1a927d4055ac086ab5f614594b7a5f302702/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:3 Changed 5 years ago by Nicola Rizzo <nicola.rizzo@…>

In 124555197da4be2b0522634db38880045d4eb3fe/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:4 Changed 5 years ago by Nicola Rizzo <nicola.rizzo@…>

In a8821502da9bc589307245e89e0e0c4925613eec/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:5 Changed 5 years ago by Nicola Rizzo <nicola.rizzo@…>

In 56683bde8e11c80f9414e1af240ecbf5401bf88b/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:6 Changed 5 years ago by nic

Milestone: tbd1.7.6
Resolution: fixed
Status: assignedclosed

Fixed and backported through 1.7.x

Note: See TracTickets for help on using tickets.