DojoX Calendar, resize() not implemented for SimpleColumnView

[Arlo White]

I have a Calendar that just uses SimpleColumnView?. I'm using this Calendar in a TabContainer? and BorderContainer?. I'm having trouble setting it's height through resize().

resize() does not seem to be implemented in ViewBase?.js

There are actually two resize declarations: ViewBase?.js:197, ViewBase?.js:856 Both do nothing.

In addition, CalendarBase?.js swallows any arguments to resize. I'm not sure if this is by design?

I've ended up just setting the Calendar.domNode height manually to get my Calendar to display within TabContainer/BorderContainer?.

[Arlo White]

Besides the minor ViewBase?.js duplication, I think this bug can be disregarded. I did not have height set correctly. So I guess resize() does not need to be implemented.

I forgot to set height: 100% when putting the Calendar into a BorderContainer?. This scrolls correctly if the Calendar.height < BorderContainer?.height

When viewing in my TabContainer?, I have doLayout: false, so I need to set an absolute height on the Calendar.

[bill]

Giving to dg to review anyway...

[dg]

I created an issue on GitHub? for this: ​https://github.com/damiengarbarino/dojo-calendar/issues/76

The replication is harmless but, of course, will be removed.

The Calendar has to apply the size passed as parameter.

Meanwhile setting height and width to 100% to the calendar usually solves this kind of issue.

Regards,

Damien

[dg]

Fixed for 1.9.2