Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#17521 closed defect (fixed)

[patch][cla] dojox/date/timezone just contains an empty obejct when loaded through require().

Reported by: Justin Bumpus-Barnett Owned by: dylan
Priority: high Milestone: 1.10
Component: Dojox Version: 1.9.1
Keywords: Cc:
Blocked By: Blocking:

Description

If I try to load dojo/date/timezone using:

require(["dojox/date/timezone"], function(timezoneUtil) {

});

, timeZoneUtil is just an empty object, {}.

On the contrary, accessing it using dojo.date.timezone, works just fine.

Change History (11)

comment:1 Changed 6 years ago by Justin Bumpus-Barnett

Fixed with this pull request: https://github.com/dojo/dojox/pull/49

comment:2 Changed 6 years ago by dylan

Do you have a CLA on file? If not, please fill out the form at http://dojofoundation.org/about/claForm .

comment:3 Changed 6 years ago by dylan

The patch itself looks fine. There are a few things I would do differently if this was a new module, but since we try to maintain forwards compatibility, they are ok (e.g. lang.setObject("dojox.date.timezone" ).

comment:4 in reply to:  2 Changed 6 years ago by Justin Bumpus-Barnett

Replying to dylan:

Do you have a CLA on file? If not, please fill out the form at http://dojofoundation.org/about/claForm .

I just filled it out.

comment:5 in reply to:  3 Changed 6 years ago by Justin Bumpus-Barnett

Replying to dylan:

The patch itself looks fine. There are a few things I would do differently if this was a new module, but since we try to maintain forwards compatibility, they are ok (e.g. lang.setObject("dojox.date.timezone" ).

Yeah, I tried to keep it as similar as possible for compatibility's sake. I had figured I'd do a straight port first, and then make those adjustments in a later commit.

comment:6 Changed 6 years ago by Justin Bumpus-Barnett

Is there anything else preventing the pull request from being merged?

comment:7 Changed 5 years ago by dylan

Milestone: tbd1.10
Owner: set to dylan
Priority: undecidedhigh
Status: newassigned
Summary: dojox/date/timezone just contains an empty obejct when loaded through require().[patch][cla] dojox/date/timezone just contains an empty obejct when loaded through require().

comment:8 Changed 5 years ago by dylan

Sorry this has taken so long, I will make sure it makes it in for 1.10.

comment:9 Changed 5 years ago by dylan

Revised pull request is at https://github.com/dojo/dojox/pull/70

comment:10 Changed 5 years ago by dylans <dylan@…>

Resolution: fixed
Status: assignedclosed

In 75be23a68db19c5d5f20976361a1e2f7441885be/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:11 Changed 5 years ago by dylan

Note: patch reviewed and fixed in https://github.com/dojo/dojox/commit/75be23a

It failed the same tests it was failing prior to the patch. While it would be nice to fix all of the failing tests, for now it is better to at least update this to be more valid AMD

Note: See TracTickets for help on using tickets.