[patch][cla] dojox/date/timezone just contains an empty obejct when loaded through require().

[Justin Bumpus-Barnett]

If I try to load dojo/date/timezone using:

require(["dojox/date/timezone"], function(timezoneUtil) {

});

, timeZoneUtil is just an empty object, {}.

On the contrary, accessing it using dojo.date.timezone, works just fine.

[Justin Bumpus-Barnett]

Fixed with this pull request: ​https://github.com/dojo/dojox/pull/49

[dylan]

Do you have a CLA on file? If not, please fill out the form at ​http://dojofoundation.org/about/claForm .

[dylan]

The patch itself looks fine. There are a few things I would do differently if this was a new module, but since we try to maintain forwards compatibility, they are ok (e.g. lang.setObject("dojox.date.timezone" ).

[Justin Bumpus-Barnett]

Replying to dylan:

Do you have a CLA on file? If not, please fill out the form at ​http://dojofoundation.org/about/claForm .

I just filled it out.

[Justin Bumpus-Barnett]

Replying to dylan:

The patch itself looks fine. There are a few things I would do differently if this was a new module, but since we try to maintain forwards compatibility, they are ok (e.g. lang.setObject("dojox.date.timezone" ).

Yeah, I tried to keep it as similar as possible for compatibility's sake. I had figured I'd do a straight port first, and then make those adjustments in a later commit.

[Justin Bumpus-Barnett]

Is there anything else preventing the pull request from being merged?

[dylan]

Sorry this has taken so long, I will make sure it makes it in for 1.10.

[dylan]

Revised pull request is at ​https://github.com/dojo/dojox/pull/70

[dylans <[email protected]…>]

In 75be23a68db19c5d5f20976361a1e2f7441885be/dojox:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

[dylan]

Note: patch reviewed and fixed in ​https://github.com/dojo/dojox/commit/75be23a

It failed the same tests it was failing prior to the patch. While it would be nice to fix all of the failing tests, for now it is better to at least update this to be more valid AMD