#17521 closed defect (fixed)
[patch][cla] dojox/date/timezone just contains an empty obejct when loaded through require().
Reported by: | Justin Bumpus-Barnett | Owned by: | dylan |
---|---|---|---|
Priority: | high | Milestone: | 1.10 |
Component: | Dojox | Version: | 1.9.1 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
If I try to load dojo/date/timezone
using:
require(["dojox/date/timezone"], function(timezoneUtil) { });
, timeZoneUtil
is just an empty object, {}
.
On the contrary, accessing it using dojo.date.timezone
, works just fine.
Change History (11)
comment:1 Changed 9 years ago by
comment:2 follow-up: 4 Changed 9 years ago by
Do you have a CLA on file? If not, please fill out the form at http://dojofoundation.org/about/claForm .
comment:3 follow-up: 5 Changed 9 years ago by
The patch itself looks fine. There are a few things I would do differently if this was a new module, but since we try to maintain forwards compatibility, they are ok (e.g. lang.setObject("dojox.date.timezone" ).
comment:4 Changed 9 years ago by
Replying to dylan:
Do you have a CLA on file? If not, please fill out the form at http://dojofoundation.org/about/claForm .
I just filled it out.
comment:5 Changed 9 years ago by
Replying to dylan:
The patch itself looks fine. There are a few things I would do differently if this was a new module, but since we try to maintain forwards compatibility, they are ok (e.g. lang.setObject("dojox.date.timezone" ).
Yeah, I tried to keep it as similar as possible for compatibility's sake. I had figured I'd do a straight port first, and then make those adjustments in a later commit.
comment:6 Changed 9 years ago by
Is there anything else preventing the pull request from being merged?
comment:7 Changed 8 years ago by
Milestone: | tbd → 1.10 |
---|---|
Owner: | set to dylan |
Priority: | undecided → high |
Status: | new → assigned |
Summary: | dojox/date/timezone just contains an empty obejct when loaded through require(). → [patch][cla] dojox/date/timezone just contains an empty obejct when loaded through require(). |
comment:8 Changed 8 years ago by
Sorry this has taken so long, I will make sure it makes it in for 1.10.
comment:10 Changed 8 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
comment:11 Changed 8 years ago by
Note: patch reviewed and fixed in https://github.com/dojo/dojox/commit/75be23a
It failed the same tests it was failing prior to the patch. While it would be nice to fix all of the failing tests, for now it is better to at least update this to be more valid AMD
Fixed with this pull request: https://github.com/dojo/dojox/pull/49