Changes between Version 1 and Version 2 of Ticket #17502, comment 12


Ignore:
Timestamp:
Nov 29, 2013, 2:45:11 PM (8 years ago)
Author:
Adrian Vasiliu
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #17502, comment 12

    v1 v2  
    1 Nebulae, concerning the ReferenceError for "win" - this shouldn't happen if you correctly imported in your test the "dojo/_base/window" module and you mapped it on the "win" variable of the require function. Anyway, both work in practice, it just that the dojo/_base/window abstraction is our standard cross-browser way to access the document.
     1Nebulae, concerning the ReferenceError for "win" - this shouldn't happen if you correctly imported in your test the "dojo/_base/window" module and you mapped it on the "win" variable of the require function. Anyway, both work in practice, it's just that the dojo/_base/window abstraction is our standard cross-browser way to access the document.
    22
    33Concerning the check for the "range" input type: sure, but the HTML slider was only an example, and there's no generic way to test whether an element needs to handle touchmove events. That said, yes, the workaround code can be adapted to cope with various custom situations - that's precisely why it fits better as a workaround than as a patch... However, we might decide to patch despite the drawbacks. We'll see.