Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#17501 closed defect (fixed)

dijitDialog CloseButton on Active

Reported by: _ Owned by: bill
Priority: undecided Milestone: 1.9.2
Component: Dijit Version: 1.9.1
Keywords: Cc:
Blocked By: Blocking:

Description

http://download.dojotoolkit.org/release-1.9.0/dojo-release-1.9.0/dijit/themes/themeTester.html

[Dialogs] → [show action bar] → click (and hold) the X close button → the icon does not change but remains displaying the hover button.

the ...Active CSS class is not appended to the HTML element.

Change History (4)

comment:1 Changed 6 years ago by bill

OK, I assume you mean the close icon should get the dijitDialogCloseIconActive class.

comment:2 Changed 6 years ago by bill

Milestone: tbd1.9.2
Owner: set to bill
Status: newassigned

I looked into it. _CssStateMixin.js has listener code on <body> and it's listening for an a11yclick.press event. Usually it works, but not when clicking on the Dialog title bar. Maybe something about the Dialog being draggable, or about how focus is automatically returned to the dialog when you click in a weird place.

I'll switch claro's CSS to use the :active pseudoclass instead. That's the plan anyway for 2.0, for all the hover and active effects. If you have your own custom CSS, then please just use the . dijitDialogCloseIcon:active selector.

Version 1, edited 6 years ago by bill (previous) (next) (diff)

comment:3 Changed 6 years ago by Bill Keese <bill@…>

Resolution: fixed
Status: assignedclosed

In c1bc942b5002a54f8af83c7449c9f86e83a4d9fa/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:4 Changed 6 years ago by Bill Keese <bill@…>

In f1dfe5577402af34309db711daa85cbc1df0d674/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 
Note: See TracTickets for help on using tickets.