Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#17493 closed defect (fixed)

Regression: dojo/text without HTTP header "X-Requested-With"

Reported by: inghamc Owned by: Colin Snover <github.com@…>
Priority: high Milestone: 1.9.4
Component: Loader Version: 1.9.1
Keywords: Cc:
Blocked By: Blocking:

Description

​https://bugs.dojotoolkit.org/ticket/14482 was fixed by adding support for dojo.config.textPluginHeaders in the call to xhr("GET",...).

When xhr was converted to request, this support was dropped, so that dojo.config.textPluginHeaders is ignored and #14482 is again broken.

Change History (4)

comment:1 Changed 5 years ago by Colin Snover <github.com@…>

Owner: set to Colin Snover <github.com@…>
Resolution: → fixed
Status: new → closed

In 56703ec1fa0bd1901b259dc83404f3db5d92c9e4/dojo:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?

comment:2 Changed 5 years ago by Colin Snover <github.com@…>

In c5e66300de4a8cc76a6e1ad338389384f19bf6af/dojo:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?

comment:3 Changed 5 years ago by Colin Snover

The textPluginHeaders configuration option from #14482 was never documented anywhere, I see no particular reason to restore it. X-Requested-With will just not be sent now with dojo/text requests.

Last edited 5 years ago by Colin Snover (previous) (diff)

comment:4 Changed 5 years ago by Colin Snover

Milestone: tbd → 1.9.4
Priority: undecided → high
Note: See TracTickets for help on using tickets.