Opened 6 years ago

Closed 3 years ago

#17462 closed defect (patchwelcome)

using depreciated function in dojox.layout.ContantPane

Reported by: vtsuper Owned by:
Priority: undecided Milestone: 1.13
Component: DojoX Layout Version: 1.9.1
Keywords: Cc:
Blocked By: Blocking:

Description

in dojox.layout.ContanePane? line 87

scriptHookReplacement: "dijit.byId('"+this.id+"')"

should change to

scriptHookReplacement: "registry.byId('"+this.id+"')"

Change History (3)

comment:1 Changed 6 years ago by bill

I don't think it's that simple. You can't use registry unless it's inside a require(dijit/registry?, ...), but that code is eval'd in I don't know what context.

comment:2 Changed 6 years ago by vtsuper

yes, you told the truth, changing to "registry.byId" is step 1 only.

and the second part is how to call registry without required it, I ask this question in here http://dojo-toolkit.33424.n3.nabble.com/enhancement-of-dojox-layout-ContentPane-tp3999368.html

comment:3 Changed 3 years ago by dylan

Milestone: tbd1.12
Resolution: patchwelcome
Status: newclosed

Given that no one has shown interest in creating a patch in the past 2+ years, I'm closing this as patchwelcome. Please let us know if you would like to get involved in helping make this change to Dojo!

Note: See TracTickets for help on using tickets.