Opened 6 years ago

Closed 4 years ago

#17445 closed defect (patchwelcome)

WindowsPhone theme issues

Reported by: Sebastien Brunot Owned by: Patrick Ruzand
Priority: undecided Milestone: 1.13
Component: DojoX Mobile Version: 1.8.1
Keywords: Cc: sgrebnov
Blocked By: Blocking:

Description (last modified by Patrick Ruzand)

Here is a list of issues with the WindowsPhone? theme, after a test campaign run on IE11 / Windows 8.1 (most of the issues are also reproduced using chrome desktop browser with the WindowsPhone? theme). All referenced tests are dojox/mobile/tests files:

1) test_EdgeToEdgeList-check.html: using WindowsPhone? theme, the category headers appears strange (a blue square on the left, the tewt overflowing it: see screenshot WindowsPhone?-CategoryHeader?.PNG). Is it a feature or a defect ? Reproduced in chrome using the WindowsPhone? theme.

2) test_EdgeToEdgeList-editable-a11y.html: on IE10+, with WindowsPhone? theme, a list in edit mode is displayed under the scroll bar on the right (see screenshot WindowsPhone?-EditableListScrollbar?.PNG).

3) test_EdgeToEdgeList-variable.html: click one of the list items -> the header cannot be seen in the displayed page. Reproduced in chrome using the WindowsPhone? theme. Same problem with test_IconContainer-single.html, where it appears that the headers is BELOW the other content.

4) test_FormControls.html: see screenshot WindowsPhone?-FormControls?.PNG -> the 'click me' label overflow the checkbox. The 'on' switch status message is far away from the switch. The radio buttons labels overflow the buttons. On chrome, the slider is not correctly displayed (ok on IE10+).

5) test_IconContainer-single-below.html: when using the WindowsPhone? theme, the popup that appears when clicking an icon container appears on top the icons, not below. Reproduced on chrome with theme WindowsPhone?.

6) test_IconMenu-6up.html: the menu is on top of the show / hide buttons instead of beeing centered in the page. There is also a border issue on the right elements of the menu (extra border / padding or margin to the right). show/hide buttons are missing in IE11. Click "Tour"-> the new view is missing a heading.

7) test_ScreenSizeAware-prop.html: on table / desktop, the background color of the left list is not correct (see screenshot WindowsPhone?-ScreenSizeAware?.PNG). Reproduced on chrome with the WindowsPhone? theme.

8) test_ScrollableView-demo-long.html: on the Categories tab, the list scroll under the transparent header, which is ugly (see screenshot WindowsPhone?-ScrollUnderHeader?.PNG). Same in test_ScrollableView-hv-vh-vf.html. Reproduced on chrome with the WindowsPhone? theme.

9) test_SimpleDialog-spinWheel.html: the spin wheel is not visible (it is there, on the left, but you cannot see it until you click it). Reproduced in chrome with WindowsPhone? theme.

10) by design of the theme, when there is a spinwheel with only one slot, it is difficult to say which value will be selected when moving it.

11) test_theme-switch.html: does not work when using the WindowsPhone? theme (cannot click the theme button at the top). Reproduced on chrome with WindowsPhone? theme.

12) Some transitions issues (when sliding, (part of the) incoming view that is displayed with the outcoming view). Reproduced on chrome with WindowsPhone? theme.

13) test_phone_setting.html: the right text of a ListItem? is not visible. Due to the 'color' property value (black) in the mblListItemRightText class. This property should not be set in for windows theme.

14) test_EdgeToEdgeList-check.html: the second category, "multiple select" is on the same line than the "check" and "uncheck" buttons instead of being in a single line. This is a theme issue. (Note also that this demo should add the "type='long'" data-dojo-props so avoid the blue square on the category labels (see point 1).

15) test_EdgeToEdgeDataList-more-v.html: click "Load More Items...". The progress indicator is not centered. This is a theme issue.

16) test_IconContainer-multi.html: click the calendar icon. The calendar opens and hide the toolbar and back button of the second view (it's then not possible to go back to the icon container view without first closing the calendar). This is a theme issue. Same issue with test_iconContainer-single-below.html.

17) test_TabBar.html: invisible labels, uncorrect sizes, overlapped labels, etc.

18) test_DatePicker2.html: DONE and CANCEL buttons are not visible on mobile

19) test_IconContainer-connect: Some icons are invisible because the width of the view matches the width of the title which is larger than the screen width.

Attachments (5)

WindowsPhone-CategoryHeader.PNG (8.4 KB) - added by Sebastien Brunot 6 years ago.
WindowsPhone-EditableListScrollbar.PNG (33.8 KB) - added by Sebastien Brunot 6 years ago.
WindowsPhone-FormControls.PNG (10.1 KB) - added by Sebastien Brunot 6 years ago.
WindowsPhone-ScreenSizeAware.PNG (34.9 KB) - added by Sebastien Brunot 6 years ago.
WindowsPhone-ScrollUnderHeader.PNG (9.7 KB) - added by Sebastien Brunot 6 years ago.

Download all attachments as: .zip

Change History (16)

Changed 6 years ago by Sebastien Brunot

Changed 6 years ago by Sebastien Brunot

Changed 6 years ago by Sebastien Brunot

Changed 6 years ago by Sebastien Brunot

Changed 6 years ago by Sebastien Brunot

comment:1 Changed 6 years ago by sgrebnov

1- by design. This is default style for WP8 list header. Headers are usually contain single symbol so it looks good. But there is special option to have background covered the whole line - data-dojo-props='type:"long"'

2, 4, 8, 9(!), 11 - looks like a problem, to be reviewed

3- not an issue, hardcoded background in test page

5- by design, I think we specified this in some place (quirks doc??)

6- top position is by design, colors and width are hardcoded. But I see there is another issue - show/hide buttons are missing in IE11

7 - easy to fix, some new dojo styles overlaps WP style, must be added with another definition to WP theme

10 - by design, must be discussed

12- for discussion (specific problems)

comment:2 Changed 6 years ago by Patrick Ruzand

Owner: set to Patrick Ruzand
Status: newassigned

comment:3 Changed 6 years ago by cjolif

Cc: sgrebnov added

comment:4 Changed 6 years ago by Patrick Ruzand

Description: modified (diff)

Description updated according to sergei reply.

comment:5 Changed 5 years ago by Patrick Ruzand

Component: DojoX MobileLoader
Description: modified (diff)
Milestone: tbd1.11
Version: 1.9.11.8.1

comment:6 Changed 5 years ago by Patrick Ruzand

Component: LoaderDojoX Mobile

comment:7 Changed 5 years ago by Patrick Ruzand <pruzand@…>

In 8e904377e51eaf59510eee2175b341a6a45466b0/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:8 Changed 5 years ago by Patrick Ruzand

Description: modified (diff)

comment:9 Changed 5 years ago by Patrick Ruzand <pruzand@…>

In fdb3f55afe2c3415ea831ee5a89465c7bb936142/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:10 Changed 5 years ago by Patrick Ruzand

Description: modified (diff)
Milestone: 1.11tbd

comment:11 Changed 4 years ago by dylan

Milestone: tbd1.12
Resolution: patchwelcome
Status: assignedclosed

Given that no one has shown interest in creating a patch in the past 2+ years, I'm closing this as patchwelcome. Please let us know if you would like to get involved in helping make this change to Dojo!

Note: See TracTickets for help on using tickets.