Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#17442 closed defect (fixed)

doh.robot support on FF23+

Reported by: haysmark Owned by: haysmark
Priority: undecided Milestone: 1.7.6
Component: TestFramework Version: 1.9.1
Keywords: Cc:
Blocked By: Blocking:

Description

There are several issues:

  1. The applet throws an error on init:
    Exception in thread "pool-1-thread-1" netscape.javascript.JSException: No such method "_nextKeyGroup" on JavaScript object
    
  2. Some users report warnings from the JVM about "mixed code."
  3. The mouse clicks in the wrong spot.

Issue 1 seems to be related to the fact that _nextKeyGroup is redefined by Robot.html; for whatever reason, Firefox does not trust the applet to invoke it, regardless of the timing of the call. A workaround is to create an intermediate function that is never overwritten to invoke the new _nextKeyGroup. There are several other instances of this behavior.

Issue 2 is a new feature in the JVM: http://docs.oracle.com/javase/7/docs/technotes/guides/jweb/mixed_code.html

Issue 3 is a new feature of Firefox: the default zoom is no longer 100%: https://support.mozilla.org/en-US/questions/963759 This fix naturally is to force your zoom to 100%. Ideally though we would find a clever way to infer it from the various reported mouse positions.

Change History (12)

comment:1 Changed 6 years ago by haysmark

Milestone: tbd1.10
Owner: set to haysmark
Status: newassigned

comment:2 Changed 6 years ago by mahays0 <mahays0@…>

In 23abc082d571cecce77d3957c405fd5399622b81/util:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:3 Changed 6 years ago by bill

Mark, that last change (23abc082d571cecce77d3957c405fd5399622b81) is breaking typeKeys(). It drops letters. See dijit/tests/form/robot/ComboBox_a11y.html. In the first few tests, in the top ComboBox?, it tries to type "California" but it comes out as "aa" or "faa" with all the other letters dropped. Likewise for when it tries to type (the nonsense string) "zxcxarax".

This was on IE8 / WinXP. Not sure about other browsers.

Last edited 6 years ago by bill (previous) (diff)

comment:4 Changed 6 years ago by bill

PS: dijit/tests/_BidiSupport/form/robot/SimpleComboBoxes.html also fails, even though it's just typing a single ":" character.

comment:5 Changed 6 years ago by haysmark

Try removing the setTimeout in nextKeyGroup and see if that fixes it.

comment:6 Changed 6 years ago by bill

Mark - cool, yes, that fixes it. I didn't try FF, but if it works there too you should check in the change.

comment:7 Changed 6 years ago by mahays0 <mahays0@…>

In 9e1dc62201b7cd06f1c052bae663882003cd3957/util:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:8 Changed 5 years ago by Colin Snover <github.com@…>

In b5c1bd5dfccfc0ed6d7b5b75b8be0cb35faefc38/util:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:9 Changed 5 years ago by mahays0 <mahays0@…>

In e6490e5ad503b97e79992bbad72f9b3953430b65/util:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:10 Changed 5 years ago by dylan

Milestone: 1.101.11

comment:11 Changed 5 years ago by bill

Milestone: 1.111.7.6
Resolution: fixed
Status: assignedclosed

Changes backported to 1.8 in 7d601b8d38e2fd40e6afe07f81b9a83b92a645a3 and 99969c749fbabda02563f775dc7ca9a11e7a2cab.

I'll check in backport for 1.7 too.

I'm going to close this ticket as fixed because I doubt we'll ever address the firefox zoom issue.

comment:12 Changed 5 years ago by Bill Keese <bill@…>

In 4e4d2a0a6afd7ec7bf8fe5c73d7dcb055c27f293/util:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 
Note: See TracTickets for help on using tickets.