#17438 closed defect (fixed)
[patch] builder fails to resolve modules that use dojo/has with other loader plugins
| Reported by: | chuckd | Owned by: | Rawld Gill |
|---|---|---|---|
| Priority: | high | Milestone: | 1.9.3 |
| Component: | BuildSystem | Version: | 1.9.1 |
| Keywords: | Cc: | cjolif | |
| Blocked By: | Blocking: |
Description
For example:
dojo/has!foo?dojo/text!foo.txt:dojo/text!bar.txt
If foo is defined to be 1 in staticHasFeatures, then the builder will output the following error:
error(302) Missing dojo/has plugin resource that was resolved at build-time. plugin resource id: dojo/has!foo?dojo/text!foo.txt:dojo/text!bar.txt; resolved plugin resource id: dojo/text!bar.txt; reference module id: test/testBuilder.
If dojo/text!bar.txt is specified instead, then the text module is correctly resolved by the builder.
Attachments (2)
Change History (18)
Changed 8 years ago by
| Attachment: | has.js.patch added |
|---|
comment:1 Changed 8 years ago by
I've attached a fix for this problem. Note that the function getAmdModule is copied verbatim from depsScan.js. It would make sense to add this function to the bc so that it can be called by depsScan and the has plugin (as well as anyone else that might need it), but I didn't do that.
Changed 8 years ago by
| Attachment: | depsScan.js.patch added |
|---|
comment:2 Changed 8 years ago by
Added patch for depsScan.js. The changes to has.js can result in nested arrays of modules returned by getAmdModules(), so the array detection logic in depsScan.js was insufficient.
comment:3 Changed 8 years ago by
Chuckd, please submit patches as documented in https://github.com/dojo/util/blob/master/CONTRIBUTING.md, thanks.
comment:4 Changed 8 years ago by
| Summary: | builder fails to resolve modules that use dojo/has with other loader plugins → [patch] builder fails to resolve modules that use dojo/has with other loader plugins |
|---|
comment:5 Changed 8 years ago by
Also, looks like you haven't filed a CLA, so be sure to do that too, thanks!
comment:6 Changed 8 years ago by
OK, I've issued a pull request for this fix: https://github.com/dojo/util/pull/7 CLA is on the way.
comment:9 Changed 8 years ago by
| Owner: | set to Rawld Gill |
|---|---|
| Status: | new → assigned |
comment:10 Changed 8 years ago by
| Cc: | cjolif added |
|---|
Someone else reported that one to me. Looks like it would be time to get that one merged.
comment:11 Changed 8 years ago by
| Priority: | undecided → high |
|---|
comment:12 Changed 8 years ago by
| Milestone: | tbd → 1.9.3 |
|---|
comment:13 Changed 8 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
comment:14 follow-up: 16 Changed 8 years ago by
| Milestone: | 1.9.3 → 1.10 |
|---|
Not sure why this was set milestone 1.9.3, the patch was only applied against master. I assume you *want* it to be in earlier versions, but you do have to actually backport for that :)
comment:15 Changed 8 years ago by
| Milestone: | 1.10 → 1.9.3 |
|---|
Fixed in 94a0d235fee5303b904c1b2f90d5b3872b92bedd (master) Fixed in 421446fdcb9f63b80b25655c6a634d30686bd401 (1.9)
Is this a 1.8 bug too?
comment:16 Changed 8 years ago by
Replying to csnover:
Not sure why this was set milestone 1.9.3, the patch was only applied against master. I assume you *want* it to be in earlier versions, but you do have to actually backport for that :)
Right. Double checking I've pushed that in my fork 1.9 branch but not in dojo/util. I've probably been interupted in the middle of the process and forgot about it later... Thanks a lot for noticing that.
Is this a 1.8 bug too?
I have not tested with 1.8 but I suspect it is.
Fix for ticket #17438