Context Navigation

← Previous Ticket
Next Ticket →

#17434 closed defect (fixed)

[regression] FilteringSelect: query options incorrect on blur

Reported by:	Ed Hager	Owned by:	bill
Priority:	undecided	Milestone:	1.7.6
Component:	Dijit - Form	Version:	1.7.0
Keywords:		Cc:
Blocked By:		Blocking:

Description

The update for ticket #12373 caused a regression error.

Steps to reproduce:

Using Dojo 1.4.x, load the Dijit FilteringSelect test page:

dijit/tests/form/_autoComplete.html?testWidget=dijit.form.FilteringSelect

Find the widget labeled ""No arrow, data store which searches and highlights matches anywhere in the string"
Enter "delaware" all lowercase.
Hit the tab key to make the widget lose focus.

The contents of the widget will change from "delaware" to "Delaware".

Using Dojo 1.8.x, load the Dijit FilteringSelect test page:

dijit/tests/form/_autoComplete.html?testWidget=dijit.form.FilteringSelect

Find the widget labeled ""No arrow, data store which searches and highlights matches anywhere in the string"
Enter "delaware" all lowercase.
Hit the tab key to make the widget lose focus.

The contents will continue to be "delaware" and you will see an error indication because the string does not match a valid choice.

The problem is in the _setDisplayedValueAttr method. The query options object for the reverse lookup is not structured properly.

var options = {
    ignoreCase: this.ignoreCase,
    deep: true
};

should be:

var options = {
    queryOptions: {
        ignoreCase: this.ignoreCase,
        deep: true
    }
};

The drop down is functioning correctly because queryOptions is being used in the _startSearch method of _SearchMixin.

Change History (8)

comment:1 Changed 7 years ago by Ed Hager

Pull request: https://github.com/dojo/dijit/pull/8

comment:2 Changed 7 years ago by Colin Snover

Version:	1.6.0 → 1.7.0

Upon bisecting, 9273c05fa1993a4bbdbcfd917a577965661bf6f9 is the first commit that makes the test case fail but based on the research in the description it appears that the actual defect is elsewhere and the changes in that commit simply exposed the bug to the test suite. The regression range is between 1.6 and 1.7 so updating version to match.

comment:3 Changed 7 years ago by bill

Milestone:	tbd → 1.7.6
Owner:	set to bill
Status:	new → assigned

Fair enough, thanks for the fix. Since I broke it I'll own the ticket. I just need to add an automated test case to tests/form/robot/_autoComplete_a11y.html (unless you want to) and then I can push your fix to the main repository.