iPhone VoiceOver screen reader picks up dummy data that needed to be removed or hidden completely

[seagulf]

dojo.dojox._base.js file around line 109 can added attribute visibility: "hidden" to hide the generated Div tag content from screen readers. In fact, there might be a better way to not put this generated Div tag contains data once this method is done.

[bill]

There's no such file as dojo.dojox._base.js. Which file did you really mean, which component is the error in (for example dojox/mobile), and what's the test case to reproduce this problem?

[seagulf]

it is in dojox.gfx._base.js file line 109. You can add attribute visibility: "hidden" to hide the generated Div tag content from screen readers. Code sample from the file _base.js around line 109:

if(!measuringNode){

measuringNode = domConstruct.create("div", {style: { position: "absolute", top: "-10000px", visibility: "hidden" left: "0" }}, win.body());

}

Thanks.

[bill]

And what's the test case to reproduce this problem?

[seagulf]

You can exam the HTML DOM in the browser to see the "div" tag is generated as the last object inside "BODY" node when you run the below test case. dojo/dojo-release-1.9.1-src/dojox/charting/tests/test_chart2d.html

This test case is using dojox.gfx._base.js class and called method b._getTextBox() in it, thus the screen reader starts reading out the values inside this generated "div" container to users. This div tag should be removed or complete hidden from the screen reader either to set visibility to hidden or remove if once it is no longer needed.

Thanks.

[seagulf]

Actually all the charting test cases will have this problem, I guess this little method is heavily used to calculate the chart axises width in the DOM node.

[seagulf]

Replying to bill:

And what's the test case to reproduce this problem?

You can exam the HTML DOM in the browser to see the "div" tag is generated as the last object inside "BODY" node when you run the below test case. dojo/dojo-release-1.9.1-src/dojox/charting/tests/test_chart2d.html This test case is using dojox.gfx._base.js class and called method b._getTextBox() in it, thus the screen reader starts reading out the values inside this generated "div" container to users. This div tag should be removed or complete hidden from the screen reader either to set visibility to hidden or remove if once it is no longer needed. Thanks.

[bill]

Yes, I saw when you explanation originally, thanks, makes sense.

Patrick, who should gfx bugs go to nowadays?

[Patrick Ruzand]

Gfx bug should go to edurocher

[Jared Jurkiewicz]

This already has a patch on another bug for the same function. See: ​https://bugs.dojotoolkit.org/ticket/17178

The patch is CLA (me).

[Eric Durocher]

Fixed by GIT commit: ​https://github.com/dojo/dojox/commit/12774a98c709acd65bd85e09d8beb7ea40e04d2d