Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#17429 closed defect (fixed)

[patch][cla] optimizeCss can produce invalid CSS for unresolved @imports

Reported by: jameyg Owned by: Rawld Gill
Priority: high Milestone: 1.10
Component: BuildSystem Version: 1.8.3
Keywords: Cc:
Blocked By: Blocking:

Description

When expanding/flattening an @import, optimizeCss may generate invalid CSS (​http://www.w3.org/TR/CSS2/syndata.html#at-rules) if the flattened css contains an @import that cannot be resolved.

for example: 

[app.css]
@import a.css
@import b.css

[a.css]
h1{font-size:110%;}

[b.css]
@import http://cdn.something.com/res/ext.css

app.css would then get improperly flattened to (@import is incorrectly placed): 

h1{font-size:110%;}
@import http://cdn.something.com/res/ext.css

Change History (2)

comment:1 Changed 5 years ago by dylan

Milestone: tbd → 1.10
Owner: set to Rawld Gill
Priority: undecided → high
Status: new → assigned
Summary: optimizeCss can produce invalid CSS for unresolved @imports → [patch][cla] optimizeCss can produce invalid CSS for unresolved @imports

comment:2 Changed 5 years ago by bill

Resolution: → fixed
Status: assigned → closed

This was fixed in ​27a481239d94044b93053a82bfd82518facb5e8d.

Last edited 5 years ago by bill (previous) (diff)
Note: See TracTickets for help on using tickets.