Opened 6 years ago

Closed 6 years ago

Last modified 5 years ago

#17425 closed enhancement (fixed)

Add build option to make source maps optional

Reported by: Ed Hager Owned by:
Priority: blocker Milestone: 1.9.4
Component: BuildSystem Version: 1.9.1
Keywords: Cc: dylan, bryanforbes, ben hockey
Blocked By: Blocking:

Description

When using the Google Closure Compiler, the build system generates source map files. To save space, those files can be deleted but the optimized files contain sourceMappingURL references. Those references can cause 404 errors when the source map option is enabled in the browser.

Add support for a boolean build option useSourceMaps. Values:

  • true - This is the default value. Source maps will be created.
  • false - Source map files will not be created and the optimized files will not contain the sourceMappingURL reference.

Change History (6)

comment:2 Changed 6 years ago by Colin Snover

Cc: dylan bforbes ben hockey added
Milestone: tbd1.10
Priority: undecidedblocker
Resolution: fixed
Status: newclosed

Added in 5f4add868fd45d8553ce462af73e883dd772f9c6 (master)

I can’t remember if we decided this should be exempt from enhancement backports and added to the 1.9 line, since the feature was added without a way to disable it. Can anyone chime in?

comment:3 Changed 6 years ago by Colin Snover

Cc: bryanforbes added; bforbes removed

comment:4 Changed 6 years ago by dylan

I believe it should be exempt, and the backport should be allowed.

comment:5 Changed 5 years ago by cjolif

This was apparently also committed in 1.9.X: https://github.com/dojo/util/commit/f5832f7d86ffbcf8e26695a91dd9a6b5db3c5ed5

so shouldn't the ticket list 1.9.whatever as the fixed release?

comment:6 Changed 5 years ago by bill

Milestone: 1.101.9.4

yes, that's the convention we use, changing the milestone

Note: See TracTickets for help on using tickets.