Opened 6 years ago

Closed 6 years ago

#17402 closed defect (fixed)

upload file with "dojox/form/upload/_IFrame", can not call onError method

Reported by: yisuren Owned by:
Priority: undecided Milestone: 1.9.3
Component: DojoX Uploader Version: 1.9.1
Keywords: Cc:
Blocked By: Blocking:

Description

in dojox/form/upload/_IFrame file I saw

			request.post(url, {
				form: sendForm,
				handleAs: "json",
				content: data
			}).then(function(result){
				domConstruct.destroy(sendForm);
				if(data["ERROR"] || data["error"]){
					self.onError(result);
				}else{
					self.onComplete(result);
				}
			}, function(err){
				console.error('error parsing server result', err);
				domConstruct.destroy(sendForm);
				self.onError(err);
			});

the following line confuse me

 "data["ERROR"] || data["error"]"

should it be ?

"result["ERROR"] || result["error"]"

so that the response from server with "ERROR" key can trigger the onError callback?

Change History (4)

comment:1 Changed 6 years ago by eduardogf

I Have alread filled a BUG #17116 in 1.9.0, and after four months, they can´t correct a single line of code.

In 1.9.1 the upload is broken.

comment:2 Changed 6 years ago by dylans <dylan@…>

In 6169b5747e2e98d1f07f4ffc23ce6b1ee1a7238b/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:3 Changed 6 years ago by dylans <dylan@…>

In 209ef31746e962ae2d74625e3e3641adb6177433/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:4 Changed 6 years ago by dylan

Component: DojoxDojoX Uploader
Milestone: tbd1.9.3
Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.