Changes between Initial Version and Version 1 of Ticket #17399, comment 20
- Timestamp:
- Oct 2, 2013, 4:03:32 PM (9 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #17399, comment 20
initial v1 1 i think calling these in `startup` is not a complete solution. isn't it possible to add an item/option after `startup` and won't those have the wrong values? maybe those values could be passed to new items when they are constructed via `_addOptionItem`? (https://github.com/dojo/dojox/commit/c58ca9ecbb439aa2a170b683995d646a12ecd3ee#commitcomment-4233729)1 i think calling these in `startup` is not a complete solution. isn't it possible to add an item/option after `startup` and won't those new items possibly have the wrong values? maybe those values could be passed to new items when they are constructed via `_addOptionItem`? (https://github.com/dojo/dojox/commit/c58ca9ecbb439aa2a170b683995d646a12ecd3ee#commitcomment-4233729) 2 2 3 3 my suggestions are just based on a cursory look at the code - maybe there's something i've missed.