Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#17399 closed defect (fixed)

Items of disabled CheckedMultiSelect not disabled

Reported by: haysmark Owned by: haysmark
Priority: high Milestone: 1.6.3
Component: DojoX Form Version: 1.6.1
Keywords: Cc:
Blocked By: Blocking:

Description

See the attached modified test case.

When you declare a CheckedMultiSelect? in markup, it calls the methods _setDisabledAttr and _setReadOnlyAttr before it registers its children. This puts the widget in a weird state where the parent is disabled but its children are not.

A simple solution would be to explicitly invoke set("disabled") and set("readOnly") in startup so that the children exist.

Attachments (1)

test_CheckedMultiSelect.html (12.8 KB) - added by haysmark 6 years ago.
Test case with disabled select in the bottom right.

Download all attachments as: .zip

Change History (32)

Changed 6 years ago by haysmark

Test case with disabled select in the bottom right.

comment:2 Changed 6 years ago by haysmark

Owner: set to haysmark
Status: newassigned

comment:3 Changed 6 years ago by haysmark

Milestone: tbd1.10
Priority: undecidedhigh

comment:4 Changed 6 years ago by haysmark

Milestone: 1.101.6.2

comment:5 Changed 6 years ago by haysmark

Version: 1.9.11.6.1

comment:6 Changed 6 years ago by Colin Snover

Milestone: 1.6.21.6.3

Retargeting all open 1.6.2 tickets to next 1.6.x milestone.

comment:7 Changed 6 years ago by mahays0 <mahays0@…>

Resolution: fixed
Status: assignedclosed

In 4f2b949cfcf45f59628484f704b04989d5586fde/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:8 Changed 6 years ago by haysmark

Resolution: fixed
Status: closedreopened

comment:9 Changed 6 years ago by haysmark

Status: reopenedassigned

comment:10 Changed 6 years ago by Colin Snover

What just happened?

comment:11 Changed 6 years ago by haysmark

Bill approved the PR, I committed, but the system assigned it to my git email instead of my trac user name, so I fixed it. I'm also in the process of backporting.

comment:12 Changed 6 years ago by Colin Snover

the system assigned it to my git email instead of my trac user name, so I fixed it

What does this even mean? What are you “fixing”?

comment:13 Changed 6 years ago by Colin Snover

At the risk of being reactive, if you mean you are trying to change the email address on the commit to be something else: you can’t. You already pushed the commit. It is done and cannot be changed. Do not attempt a force push to “fix” it or you will lose push permissions.

comment:14 in reply to:  13 ; Changed 6 years ago by haysmark

Replying to csnover:

What does this even mean? What are you “fixing”?

Every time I commit, Git always sets the Trac ticket's "Owned By" field to my Git id. I would prefer that it left the field as my Trac id.

Replying to csnover:

At the risk of being reactive, if you mean you are trying to change the email address on the commit to be something else: you can’t. You already pushed the commit. It is done and cannot be changed. Do not attempt a force push to “fix” it or you will lose push permissions.

I am aware of the dangers of rebasing repos that other people use and that has not happened here.

comment:15 Changed 6 years ago by mahays0 <mahays0@…>

Resolution: fixed
Status: assignedclosed

In c58ca9ecbb439aa2a170b683995d646a12ecd3ee/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:16 Changed 6 years ago by mahays0 <mahays0@…>

In 70399a64a6938c5ce524a642f5fabcd88d253b58/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:17 Changed 6 years ago by Colin Snover

Though I have seen it happen in the past, the owner never changed on this ticket, so that confused me. Thank you for clarifying.

comment:18 Changed 6 years ago by mahays0 <mahays0@…>

In 2eee8b4032c704d21c8f4e41787da4710c4729c4/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:19 in reply to:  14 Changed 6 years ago by bill

Replying to haysmark:

Every time I commit, Git always sets the Trac ticket's "Owned By" field to my Git id. I would prefer that it left the field as my Trac id.

From what I've seen, that only happens when there's no owner previously set, and then it shows a message about the owner being changed, for example see https://bugs.dojotoolkit.org/ticket/17418#comment:4). According to the history of this ticket, there's only one place where it says "owner set to", in comment:2. Looks like neither comment:7 nor comment:9 changed the owner, otherwise those comments would have "owner changed" messages.

comment:20 Changed 6 years ago by ben hockey

i think calling these in startup is not a complete solution. isn't it possible to add an item/option after startup and won't those new items possibly have the wrong values? maybe those values could be passed to new items when they are constructed via _addOptionItem? (https://github.com/dojo/dojox/commit/c58ca9ecbb439aa2a170b683995d646a12ecd3ee#commitcomment-4233729)

my suggestions are just based on a cursory look at the code - maybe there's something i've missed.

Last edited 6 years ago by ben hockey (previous) (diff)

comment:21 in reply to:  20 Changed 6 years ago by haysmark

Replying to neonstalwart:

i think calling these in startup is not a complete solution. isn't it possible to add an item/option after startup and won't those new items possibly have the wrong values? maybe those values could be passed to new items when they are constructed via _addOptionItem? (https://github.com/dojo/dojox/commit/c58ca9ecbb439aa2a170b683995d646a12ecd3ee#commitcomment-4233729)

Apparently it is much worse that you thought: if you add a new item, all of the old items are deleted and reconstructed, so it gives the appearance of resetting the disabled state of every item. I agree that the logic needs to happen earlier.

comment:22 Changed 6 years ago by mahays0 <mahays0@…>

In ead78ed67c4ee46c953adf95d72a63acbcc945b8/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:23 Changed 6 years ago by mahays0 <mahays0@…>

In 2b1146249d7579836c229e3bf34ea74596f6bdb0/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:24 Changed 6 years ago by mahays0 <mahays0@…>

In 554c95b5d1ffe6a3984aaec4ab285ad090a92594/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:25 Changed 6 years ago by mahays0 <mahays0@…>

In 2c2a9abee039612eb43d40fadb3e233a99f5e45e/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:26 Changed 6 years ago by mahays0 <mahays0@…>

In f081b6288232b65177059b192bbba3124a3e7fd8/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:27 Changed 6 years ago by mahays0 <mahays0@…>

In 571857724ce78f2fde8802ad33f5e5f3a104d0a1/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:28 Changed 6 years ago by mahays0 <mahays0@…>

In 9c9a736b4ba28aa18a5842469766a61be23e9882/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:29 Changed 6 years ago by mahays0 <mahays0@…>

In 5293dceca8599025b03b84b34fb243183d04d481/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:30 Changed 6 years ago by mahays0 <mahays0@…>

In 780659ce5333cb0089464a0292f9311ab4dff7b4/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:31 Changed 6 years ago by mahays0 <mahays0@…>

In 48b1df6960a517e3c602a21e9e855d274b64966e/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 
Note: See TracTickets for help on using tickets.