ValidationTextBox constructor sets constraints to {}

[patrickzope]

The ValidationTextBox?'s constructor sets the constraints attribute to {}, a value which is also defined as an attribute in the call to dojo/_base/declare.

This makes it impossible to declare subclasses of ValidationTextBox? that simply set the constraints and pattern attributes like so:

declare(ValidationTextBox, {
  constraints: {allowCruft: false},
  pattern: dojox.validate.regexp.emailAddress
});

[dylan]

In order to preserve getters/setters, I think you really want something like this (you really don't want to set constraints on the prototype, you want to set them on the constructor)

declare(ValidationTextBox, {
  constructor: function(params){
    constraints: {allowCruft: false},
    pattern: dojox.validate.regexp.emailAddress
  }
});

[bill]

That's the workaround, although it would be better to be able to set constraints on the prototype.

That weird code is from 8c26273a5ed64033fddfdb1035bff435fe421bab and [7558] and [10412], as a workaround to the problem that dojo.regexp writes directly to the object passed in.

In any case it's not something that we fixed in 1.9.2, so we should either mark this as wontfix or actually fix it.

[sunxcint]

I think there are two folds for this defect

1. Constraints can be set on the prototype;
2. Constraints can be modified in one instance independently from other instances.

Please see my fix in the attached patch.txt.

[bill]

Looks reasonable although we need an automated test case before checking it in.

[sunxcint]

Basic.js is a test case for my patch. (I did want to modify its name to be testcase.js but I did not figure out how to do it. Sorry!)

[doughays-dojo <[email protected]…>]

In 46ea1d899811988d545bf5974a5326e53fa5e484/dijit:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?