#17380 closed defect (fixed)
dojox/mobile/FormLayout assumes dot notation for css rules
Reported by: | csantanapr | Owned by: | Damien Mandrioli |
---|---|---|---|
Priority: | high | Milestone: | 1.9.2 |
Component: | DojoX Mobile | Version: | 1.9.1 |
Keywords: | Cc: | ben hockey | |
Blocked By: | Blocking: |
Description
When the widget dojox/mobile/FormLayout is used certain rules are not applied when using uses slash / notation in data-dojo-type like dojox/mobile/TextBox
like: <form data-dojo-type="dojox/mobile/FormLayout"
data-dojo-attach-point="formLayout">
<label><span class="labelForm">${nls.id}</span>
<input class="valueForm" name="id" data-dojo-type="dojox/mobile/TextBox"
data-dojo-props="readOnly: true, placeHolder: '${nls.id}'" data-dojo-attach-point="reqid">
</label>
</form>
The file https://github.com/dojo/dojox/blob/master/mobile/themes/common/FormLayout.less
contain rules only for dot notations is missing slash notation.
.mblFormLayout.mblFormLayoutAuto *[data-dojo-type="dojox.mobile.TextArea?"],
.mblFormLayout.mblFormLayoutAuto *[data-dojo-type="dojox.mobile.ExpandingTextArea?"], .mblFormLayout.mblFormLayoutAuto *[data-dojo-type="dojox.mobile.TextBox?"], .mblFormLayout.mblFormLayoutAuto *[data-dojo-type="dojox.mobile.ComboBox?"], .mblFormLayout.mblFormLayoutAuto *[data-dojo-type="dojox.mobile.SearchBox?"]{
width: 100%; box-sizing: border-box;
}
Also the tests are written in dot notation, I think they should use new convention https://github.com/dojo/dojox/blob/master/mobile/tests/test_FormLayout.html
<div data-dojo-type="dojox.mobile.FormLayout?" data-dojo-props="rightAlign: false, columns:'single'">
<div>
<label>Buttons</label> <fieldset>
<button data-dojo-type="dojox.mobile.Button">Help</button> <input type="submit" class="mblBlueButton" data-dojo-type="dojox.mobile.Button" value="Submit"> <button class="mblRedButton" data-dojo-type="dojox.mobile.Button">Cancel</button>
</fieldset>
</div>
</div>
Change History (5)
comment:1 Changed 6 years ago by
Cc: | ben hockey added |
---|
comment:2 Changed 6 years ago by
Owner: | set to Damien Mandrioli |
---|---|
Priority: | undecided → high |
Status: | new → assigned |
comment:3 Changed 6 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
comment:5 Changed 6 years ago by
Milestone: | tbd → 1.9.2 |
---|
In 617ca08bd4cced576d76ce0bd27450caa3f08250/dojox: