Opened 4 years ago

Last modified 11 months ago

#17375 reopened defect

[patch] [no cla?] Dojo 1.9.1 EnhancedGrid Click & RIght-Click on Header invokes splitter.

Reported by: brijeshamin Owned by:
Priority: undecided Milestone: 1.15
Component: DojoX Grid Version: 1.9.1
Keywords: Cc:
Blocked by: Blocking:

Description

Steps:

  1. Open a page which contains EnhancedGrid with headers.
  2. Click on any column header.
  3. Notice that column splitter gets invoked.
  4. The same problem is observed with Right-click too.

This behavior creates problems with the column reordering feature.

Attachments (1)

column_reorder.diff (3.3 KB) - added by mwp 4 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 4 years ago by craign

This seems to be related to #17086. It only effects FF.

The sorting works if you manage to click outside the mouse over highlight.

Last edited 4 years ago by craign (previous) (diff)

comment:2 Changed 4 years ago by craign

#17130 details the underlying issue. Removing the workaround in createView in the enhanced grid seems to resolve the sorting issue.

Changed 4 years ago by mwp

comment:3 Changed 4 years ago by mwp

The attached file column_reorder.diff provides a patch.

Subsequent sorts after the initial sorting of the table sometimes invoke the column resizer without this patch. It depends on exactly where the user clicks in the cell heading though. This only happens in Firefox. This can be seen in test case provided.

Thanks to craign for developing this fix.

comment:4 Changed 3 years ago by bill

  • Resolution set to patchwelcome
  • Status changed from new to closed

DojoX Grid and EnhancedGrid are deprecated in favor of dgrid and gridx.

You should upgrade your code to use one of those two grids.

We will consider patches to the old DojoX Grid code though.

comment:5 Changed 3 years ago by craign

The patch was attached?

comment:6 Changed 3 years ago by bill

  • Resolution patchwelcome deleted
  • Status changed from closed to reopened
  • Summary changed from Dojo 1.9.1 EnhancedGrid Click & RIght-Click on Header invokes splitter. to [patch] [no cla?] Dojo 1.9.1 EnhancedGrid Click & RIght-Click on Header invokes splitter.

Ah right. Well, I'll reopen the ticket but I can't guarantee that anyone will actually apply the patch.

Two questions though:

  1. The patch is just removing a bunch of code from EnhancedGrid.js. Does that really fix the problem without causing other issues?
  2. Who is "mwp" and has he filed a CLA? I don't see one for him.

comment:7 Changed 3 years ago by craign

Regarding 1. I think this code was added to override getCellX in some specific circumstances in Firefox that don't seem to exist anymore.

Regarding 2, Yes, I believe Michael Paddon (mwp) has signed the CLA.

Last edited 3 years ago by craign (previous) (diff)

comment:8 Changed 20 months ago by dylan

  • Milestone changed from tbd to 1.12

To get any progress on this, I suggest an updated pull request, as the patch is fairly old. If you want to do that, I'll review and land it.

comment:9 Changed 11 months ago by dylan

  • Milestone changed from 1.13 to 1.15

Ticket planning... move current 1.13 tickets out to 1.15 to make it easier to move tickets into the 1.13 milestone.

Note: See TracTickets for help on using tickets.