FloatingPane destroy does not destroy its resize handle (leak)

[yh_mailinglist@…]

After calling destroy on a FloatingPane?, its resizeHandle is not destroyed and can still be accessed from dojo.widget.manager.widgets.

the pb is in function fillInTemplate,

the line

this.resizeBar.appendChild(this.resizeHandle.domNode);

should actually be

this.addChild(this.resizeHandle, this.resizeBar);

pb found in 0.3.1, but it is also present in 0.4

[guest]

comment: the fix I have suggested works only with dynamically created floating panes. It breaks floating panes created statically (no resize handle anymore).

[yh]

I think the proper way to fix the pb is:

destroy: function() {

if (this.resizeHandle){

this.resizeHandle.destroy(); this.resizeHandle = null;

}

return dojo.widget.FloatingPane?.superclass.destroy.call(this);

},

[bill]

Cougar is going to fix; I don't want to do an addChild() because then the resizeHandle widget will show up in the children[] array, which is not what the user expects. But it should be deleted in the destroy() method.

[liucougar]

fixed in [6307]

[(none)]

Milestone 0.4.1 deleted