Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#17368 closed defect (worksforme)

clarify charOrCode

Reported by: sol Owned by:
Priority: undecided Milestone: tbd
Component: Events Version: 1.9.1
Keywords: Cc:
Blocked By: Blocking:

Description

charOrCode in keyboard events is at the mom. only available if has("dom-addeventlistener") fails. i dont think this is intentionaly. in the docu the charOrCode option is still mentioned. in the tickets i found some talk about deprication.

please clarify!

Change History (5)

comment:1 Changed 6 years ago by bill

Resolution: worksforme
Status: newclosed

AFAIK charOrCode is available on all events registered like

dojo.connect(node, "keypress", handler);

It's not there when you use dojo/on or "keydown".

If the above code isn't working for you on mozilla/gecko you can attach a test case.

comment:2 Changed 6 years ago by sol

thanks for clarifying. since the docu wasnt clear about it. or at least my understanding of it wasnt. i made a

grep -r -i charOrCode *

in the dojo directory on.js came up as a hit and i studied the code. why is it present in on.js if it is only needed in connect? ah nevermind im not using it anyway.

thx again

comment:3 Changed 6 years ago by bill

Note that charOrCode, like dojo.connect(), is deprecated (so it's good you're not using it). I imagine the charOrCode reference is in on.js just as an easy way to maintain backwards compatibility for dojo.connect(), which is built on top of dojo/on.

Last edited 6 years ago by bill (previous) (diff)

comment:4 Changed 6 years ago by Bill Keese <bill@…>

In 7904124bc591f3bd3522ac92a9358a7833c9f256/dojo:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:5 Changed 6 years ago by sol

ok thanks again guys - just make sure to make that clear in the docs ok?

Note: See TracTickets for help on using tickets.