Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#17358 closed defect (fixed)

[regression] StackController: W key improperly prevented

Reported by: bill Owned by: bill
Priority: undecided Milestone: 1.9.2
Component: Dijit Version: 1.9.1
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by bill)

StackController? is supposed to respond to Ctrl-W to close a tab, but the plain W key should be ignored. Starting in 1.9, the code is calling evt.preventDefault().

This is causing a problem for custom code that replaces the tab label with an InlineEditBox?. See attached test case.

Attachments (1)

stackcontainer.html​ (2.0 KB) - added by bill 6 years ago.
test case where this bug prevents entering W into an InlineEditBox?

Download all attachments as: .zip

Change History (4)

Changed 6 years ago by bill

Attachment: stackcontainer.html​ added

test case where this bug prevents entering W into an InlineEditBox?

comment:1 Changed 6 years ago by bill

Description: modified (diff)
Milestone: tbd → 1.9.2
Owner: set to bill
Status: new → assigned
Summary: StackController: W key improperly stopped → [regression] StackController: W key improperly prevented

comment:2 Changed 6 years ago by Bill Keese <bill@…>

Resolution: → fixed
Status: assigned → closed

In 9eb5409b9b6d0c47dda4854e9f2e39ec8f920923/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?

comment:3 Changed 6 years ago by Bill Keese <bill@…>

In ab187ff8aeecd9cfcd7e32b1e37656284531fea3/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?
Note: See TracTickets for help on using tickets.