Opened 8 years ago

Last modified 5 years ago

#17353 open defect

[PATCH][CLA][needs test] _AutoCompleterMixin doesn't behave with contains; queryExpr: "*${0}*"

Reported by: Andrew Muraco Owned by:
Priority: undecided Milestone: 1.15
Component: Dijit - Form Version: 1.8.1
Keywords: Cc:
Blocked By: Blocking:

Description

Related Ticket: #17230

The autoComplete feature of ComboBox/FilteringSelect? acts poorly when a contains queryExpr is used "*${0}*", but works wonderfully when the queryExpr is startsWith "${0}*".

In pull request ​https://github.com/dojo/dijit/pull/4, I've added a check to see if the autoComplete is a starts with for the normal autocomplete behavior, or early exits when it is a contains match.

The pull request is againist the latest in master, but also was tested against 1.8.1.

Change History (6)

comment:1 Changed 8 years ago by bill

Owner: set to Douglas Hays
Status: new → assigned

comment:2 Changed 7 years ago by Douglas Hays

Owner: Douglas Hays deleted
Status: assigned → open

comment:3 Changed 7 years ago by dylan

Milestone: tbd → 1.10
Owner: set to bill
Status: open → assigned

comment:4 Changed 7 years ago by bill

Milestone: 1.10 → tbd
Owner: bill deleted
Status: assigned → open

comment:5 Changed 5 years ago by dylan

Milestone: tbd → 1.12
Summary: [PATCH][CLA] _AutoCompleterMixin doesn't behave with contains; queryExpr: "*${0}*" → [PATCH][CLA][needs test] _AutoCompleterMixin doesn't behave with contains; queryExpr: "*${0}*"

This pr needs a test before it will be considered...

comment:6 Changed 5 years ago by dylan

Milestone: 1.13 → 1.15

Ticket planning... move current 1.13 tickets out to 1.15 to make it easier to move tickets into the 1.13 milestone.

Note: See TracTickets for help on using tickets.