Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#17347 closed defect (fixed)

[regression] Tree: clicking node's plus sign can scroll to top of tree

Reported by: bill Owned by: Bill Keese <bill@…>
Priority: undecided Milestone: 1.9.2
Component: Dijit Version: 1.9.1
Keywords: Cc:
Blocked By: Blocking:

Description

On api.dojotoolkit.org:

1) click the plus sign next to "dijit" 2) click in the pane on the right 3) scroll the tree down using the scroll bar 4) click the plus sign next to "registry"

At this point the Tree scrolls to the top again.

Happens at least on chrome, and apparently it's related to the Tree.focus() method itself, which is getting called when you click the plus sign next to "registry".

Change History (3)

comment:1 Changed 6 years ago by bill

Milestone: tbd1.9.2
Summary: Tree: clicking node's plus sign can scroll to top of tree[regression] Tree: clicking node's plus sign can scroll to top of tree

In this scenario, the final step focus the tree, so _KeyNavMixin._onContainerFocus() calls Tree.focus(), which shifts focus to the last focused node.

Presumably a regression from 4d8a0547a607a157666e5563388838aa5784353f, from #16323 (see the complaints in that ticket demanding that tabbing into a tree go to the previously focused node).

comment:2 Changed 6 years ago by Bill Keese <bill@…>

Owner: set to Bill Keese <bill@…>
Resolution: fixed
Status: newclosed

In 8a13496a301eaa5f0cbe6b984cb95af19b99acff/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:3 Changed 6 years ago by Bill Keese <bill@…>

In 2fd9dd53e2bb031cd632fb45015b1c1b13f00c89/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 
Note: See TracTickets for help on using tickets.