Opened 6 years ago

Last modified 3 years ago

#17346 assigned defect

Error on digit widgets reference guide using IE

Reported by: ccm7 Owned by: Kitson Kelly
Priority: undecided Milestone: 1.15
Component: Documentation Version: 1.9.1
Keywords: Cc:
Blocked By: Blocking:

Description

I was trying to learn about writing some widgets using Dojo and I've find an error using Internet Explorer 7.

On http://dojotoolkit.org/reference-guide/1.9/quickstart/writingWidgets.html all samples returns an message about "undefined" is null...

I've made the same test using Internet Explorer 8, Dojo 1.6, 1.7, 1.8 and 1.9 and I got the same error.

Attachments (4)

errormsg1.png (68.3 KB) - added by ccm7 6 years ago.
errormsg2.png (68.4 KB) - added by ccm7 6 years ago.
errormsg3.png (62.7 KB) - added by ccm7 6 years ago.
errordebug.png (2.0 KB) - added by ccm7 6 years ago.

Download all attachments as: .zip

Change History (9)

Changed 6 years ago by ccm7

Attachment: errormsg1.png added

Changed 6 years ago by ccm7

Attachment: errormsg2.png added

Changed 6 years ago by ccm7

Attachment: errormsg3.png added

Changed 6 years ago by ccm7

Attachment: errordebug.png added

comment:1 Changed 6 years ago by bill

Component: DijitDocumentation
Owner: set to Kitson Kelly
Status: newassigned

Not sure what's going on, but on Chrome it pulls in dojo from _static and on IE it pulls it in from ajax.dojotoolkit.org 1.8.0 version. Kitson, this is from your checkin https://github.com/phiggins42/rstwiki/commit/b078f0e1c4ceeaaf7741173114df02dedb42a4d6 which claims to fix IE, but doesn't seem like it's working.

comment:2 Changed 6 years ago by Kitson Kelly

I will take a look at it.

The reason why we pull from CDN for IE has to do with a strange bug in IE9 where loading code in an IFRAME from the same host gets treated as cross origin, when in fact it is same origin and so the examples do not work.

I think I forgot to repoint the CDN at 1.9.X when I built the reference guide.

comment:3 Changed 6 years ago by bill

Summary: Error on digit widgets reference guide using IE 7Error on digit widgets reference guide using IE

Thanks. FYI, I don't think this is an IE bug. The same origin policy means having the same machine name etc. as the iframe's src attribute, but in our case the iframe's src attribute is javascript://..., so there's no origin at all.

Anyway, I imagine this problem can be solved in two ways:

  1. set async:true by default
  2. make the documentation build put each example into it's own file, and have the iframe load from that file

comment:4 Changed 3 years ago by dylan

Milestone: tbd1.12

comment:5 Changed 3 years ago by dylan

Milestone: 1.131.15

Ticket planning... move current 1.13 tickets out to 1.15 to make it easier to move tickets into the 1.13 milestone.

Note: See TracTickets for help on using tickets.