Opened 6 years ago

Last modified 3 years ago

#17331 new enhancement

[patch] GanttChart Highlight in MultiTab Application Fix

Reported by: shauki Owned by: Eugene Lazutkin
Priority: undecided Milestone: 1.15
Component: Charting Version: 1.9.1
Keywords: Cc: cjolif
Blocked By: Blocking:

Description

When the highlight div is created, the window is used as the parent for it, so when opening tabs in a rich application - the highlight is always visible. The fix is to use this.tableControl as the parent for it and correspondingly adjust the new math for the position.

Modifications to the original code are in bold:

postBindEvents: function() {

var pos = domGeometry.position(this.tableControl, true); has("dom-addeventlistener") && this._events.push(

on(this.tableControl, "mousemove", lang.hitch(this, function(event) {

var elem = event.srcElement if (elem === this.panelNames.firstChild
event.target;
elem === this.contentData.firstChild) {

var rowHeight = this.heightTaskItem + this.heightTaskItemExtra; var hlTop = parseInt(event.layerY / rowHeight - 1) * rowHeight + this.panelTimeHeight - this.contentData.scrollTop; if (hlTop !== this.oldHLTop && hlTop < (pos.h - 50)) {

if (this.highLightDiv) {

domStyle.set(this.highLightDiv, "top", (pos.y + hlTop) + "px");

} else {

this.highLightDiv = domConstruct.create("div", {

className: "ganttRowHighlight"

}, this.tableControl/*win.body()*/); domStyle.set(this.highLightDiv, {

top: (/*pos.y + */hlTop) + "px", left: "0px", width: (pos.w - 20) + "px", height: rowHeight + "px"

});

}

} this.oldHLTop = hlTop;

}

}))

);

},

Change History (4)

comment:1 Changed 6 years ago by bill

Component: GeneralDojox
Owner: set to Adam Peller

comment:2 Changed 6 years ago by Adam Peller

Cc: cjolif added
Component: DojoxCharting
Owner: changed from Adam Peller to Eugene Lazutkin

comment:3 Changed 3 years ago by dylan

Milestone: tbd1.12
Summary: GanttChart Highlight in MultiTab Application Fix[patch] GanttChart Highlight in MultiTab Application Fix

comment:4 Changed 3 years ago by dylan

Milestone: 1.131.15

Ticket planning... move current 1.13 tickets out to 1.15 to make it easier to move tickets into the 1.13 milestone.

Note: See TracTickets for help on using tickets.