Opened 13 years ago

Closed 12 years ago

#1733 closed defect (fixed)

fix widget in template implementation

Reported by: alex Owned by: liucougar
Priority: high Milestone: 0.9beta
Component: Widgets Version: 0.4
Keywords: Cc:
Blocked By: Blocking:

Description

the current implementation of widgets in templates is pretty janky. In addition to having hard-coded attachPoint values, it iterates far too much and doesn't reuse the existing parsing/attachment code. A sane implementation should at least avoid code duplication.

Change History (4)

comment:1 Changed 13 years ago by liucougar

which "hard-coded attachPoint values" do you refer to?

I chose subContainerWidget as the counterpart to containerNode (which is also hard-coded for none widget containers)

comment:2 Changed 13 years ago by bill

Milestone: 0.4.10.5

OK, let's mark this as 0.5 for now, and then if all the other 0.4.1 bugs get finished early come back to it. (The current code is working so code cleanup is not time critical.)

comment:3 Changed 12 years ago by bill

Milestone: 0.90.9beta
Owner: changed from alex to liucougar

Cougar has a nice new implementation which he will check in soon.

comment:4 Changed 12 years ago by liucougar

Resolution: fixed
Status: newclosed

(In [8503]) fixes #2821 and #1733 Now all domevent names in template should be in its original case (onClick on a domnode does not work any more, you have to use onclick:onClick in dojoAttachEvent for this case) D.O.H module for dijit

Note: See TracTickets for help on using tickets.