Opened 6 years ago

Closed 4 years ago

Last modified 4 years ago

#17320 closed enhancement (fixed)

[patch] Show or hide markers for specific series

Reported by: stelian56 Owned by: dylan
Priority: undecided Milestone: 1.11
Component: Charting Version: 1.9.1
Keywords: Cc:
Blocked By: Blocking:

Description

Currently there is no way to show/hide markers on a certain series in a Default type plot. When a series is added to the plot via the dojox.charting.Chart.addSeries(seriesName, series, kwArgs) method, the kwArgs.markers property, if defined, is ignored when the plot is rendered.

Please consider applying the patch below to allow the series' markers property to override the plot-wide markers property.

Source file: dojox/charting/plot2d/Default.js.

...
render: function(dim, offsets){
...
  for(var i = this.series.length - 1; i >= 0; --i){
  ...

  // Begin patch
  // Replace this line
  // if(this.opt.markers){
  // with the line below:
     if (run.markers || run.markers == undefined && this.opt.markers) {
  // End patch

       var markerTheme = theme; 
...

Sample use:

myChart.addPlot("MyPlot", {markers: false});
myChart.addSeries("MySeriesName", mySeries, {plot: "MyPlot", markers: true});

Change History (3)

comment:1 Changed 4 years ago by dylan

Milestone: tbd1.11
Owner: set to dylan
Status: newassigned
Summary: Show or hide markers for specific series[patch] Show or hide markers for specific series

comment:2 Changed 4 years ago by dylans <dylan@…>

Resolution: fixed
Status: assignedclosed

In 98a9901919113408b3de62c0af8b40fc285ec0b5/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:3 Changed 4 years ago by dylan

Thanks for the fix stelian56, sorry this took a while to review and land.

Note: See TracTickets for help on using tickets.